Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: upgrade ethers v5 -> v6 #1255

Merged
merged 41 commits into from
Oct 16, 2023
Merged

feat: upgrade ethers v5 -> v6 #1255

merged 41 commits into from
Oct 16, 2023

Conversation

danielbate
Copy link
Contributor

@danielbate danielbate commented Sep 14, 2023 •
edited

This PR is part of the efforts to support browser testing in #284 to upgrade packages to natively support ES modules. Ethers v5 -> v6 introduces this change.

The purpose of this PR is to upgrade functions/package to their v6 counterpart, or swap them out for something else if required. This guide has been mostly followed, or via the v6 documentation.

Closes #1316

@danielbate danielbate self-assigned this Sep 14, 2023
@danielbate danielbate changed the title feat: upgrade ethers v6 feat: upgrade ethers v5 -> v6 Sep 15, 2023
@danielbate danielbate assigned Dhaiwat10 and unassigned danielbate Sep 15, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 21, 2023 •
edited

Coverage report

St.❔
 Category Percentage Covered / Total
🟢 Statements
84.86% (+0% 🔼)
 5274/6215
🟡 Branches
66.78% (+0.03% 🔼)
 772/1156
🟡 Functions
74.25% (-0.04% 🔻)
 868/1169
🟢 Lines
84.91% (-0.01% 🔻)
 5041/5937
Show new covered files 🐣
St.❔
 File Statements Branches Functions Lines
🟢
... / concatBytes.ts
 100% 100% 100% 100%
Show files with reduced coverage 🔻
St.❔
 File Statements Branches Functions Lines
🟢
... / function-fragment.ts
78.65% (-0.24% 🔻)
 69.57% 81.82%
81.58% (-0.24% 🔻)
🔴
... / provider.ts
57.02% (-0.5% 🔻)
 45.59% 53.45%
58.37% (-0.53% 🔻)
🟢
... / mnemonic.ts
98.61% (-0.06% 🔻)
 88% 100%
98.55% (-0.06% 🔻)
🟢
... / utils.ts
81.58% (-0.24% 🔻)
 56.25% 100%
80.56% (-0.27% 🔻)
🟢
... / hdwallet.ts
94.85% (-0.05% 🔻)
 80.39% 100%
94.79% (-0.05% 🔻)
🟡
... / hasher.ts
72.22% (-0.51% 🔻)
 44.44% 100%
72.22% (-0.51% 🔻)
🟢
... / index.ts
 100% 100%
33.33% (-66.67% 🔻)
 100%

Test suite run success

1270 tests passing in 223 suites.

Report generated by 🧪jest coverage report action from 21e80f3

@danielbate danielbate self-assigned this Oct 4, 2023
@Dhaiwat10 Dhaiwat10 mentioned this pull request Oct 5, 2023
Merged
Dhaiwat10 and others added 5 commits October 5, 2023 15:46
@Dhaiwat10
refactor: migrate from arrayify to getBytes (#1315)
464f908 
* initiate arrayify -> getBytes migration

* purge arrayify further

* more replacements

* export `getBytes` from `fuels` (as `arrayify`)

* add changeset
@danielbate
feat: alter arrayify mock to use getBytes
bcd4fa0
@danielbate
feat: purge ethers project dep
20d3841
@danielbate
chore: regen lock file
14a8ea3
@danielbate
feat: migrate arrayify to getBytes in hdwallet
667dda1
Dhaiwat10
Dhaiwat10 previously approved these changes Oct 6, 2023
View reviewed changes
@Dhaiwat10
Copy link
Member

Excellent work @danielbate 🪄

Dhaiwat10
Dhaiwat10 previously approved these changes Oct 10, 2023
View reviewed changes
nedsalk
nedsalk previously approved these changes Oct 10, 2023
View reviewed changes
arboleya
arboleya previously approved these changes Oct 12, 2023
View reviewed changes
Copy link
Member

@arboleya arboleya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very meticulous. Great stuff!

There are conflicts to fix, though.

@danielbate danielbate dismissed stale reviews from arboleya, nedsalk, and Dhaiwat10 via 87c7bca October 13, 2023 12:27
@danielbate danielbate enabled auto-merge (squash) October 13, 2023 12:28
@danielbate danielbate merged commit cfb06e8 into master Oct 16, 2023
8 checks passed
@danielbate danielbate deleted the db/feat/upgrade-ethers-v6 branch October 16, 2023 10:20
@github-actions github-actions bot mentioned this pull request Oct 16, 2023
Merged
@danielbate danielbate mentioned this pull request Nov 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arboleya arboleya arboleya approved these changes

@camsjams camsjams camsjams approved these changes

@digorithm digorithm Awaiting requested review from digorithm digorithm is a code owner

@Torres-ssf Torres-ssf Awaiting requested review from Torres-ssf Torres-ssf is a code owner

@Dhaiwat10 Dhaiwat10 Awaiting requested review from Dhaiwat10 Dhaiwat10 is a code owner

@nedsalk nedsalk Awaiting requested review from nedsalk nedsalk is a code owner

Assignees

@danielbate danielbate

@Dhaiwat10 Dhaiwat10

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade ethers v5 -> v6
5 participants
@danielbate @Dhaiwat10 @arboleya @camsjams @nedsalk