Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade ethers v5 -> v6 #1316

Closed
danielbate opened this issue Oct 4, 2023 · 1 comment · Fixed by #1255
Closed

Upgrade ethers v5 -> v6 #1316

danielbate opened this issue Oct 4, 2023 · 1 comment · Fixed by #1255
Assignees

Comments

@danielbate
Copy link
Contributor

Ethers v6 came out earlier in the year so we should upgrade to future proof and benefit from the additional optimisations that come from the version upgrade, such as ES module support that will aid our efforts to support browser testing (pre-requisite for Vitest implementation #813). v6 has also cleaned up a lot of the code and brought stricter function signatures so seems to have been developed with defensive programming in mind.

@danielbate
Copy link
Contributor Author

danielbate commented Oct 4, 2023

Upgrades:

  • sha
  • pbkdf2
  • network
  • basex
  • bytes (BytesLike)
  • hexSlide
  • hexlify

Remove:

Augment:

  • arrayify - now getBytesCopy (getBtyesCopy is used over getBytes to avoid issues where a Buffer could be passed in and is then not returned as a UInt8Array)
  • concat - the function signature has been made stricter here and now only returns a string, we should look to implement our own bytes concatenation function also

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant