-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: various fixes and improvements #355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Total Coverage: 88.41% Coverage Report
|
Total Coverage: 88.41% Coverage Report
|
1 similar comment
Total Coverage: 88.41% Coverage Report
|
Total Coverage: 88.41% Coverage Report
|
Total Coverage: 88.41% Coverage Report
|
Total Coverage: 88.41% Coverage Report
|
1 similar comment
Total Coverage: 88.41% Coverage Report
|
luizstacio
approved these changes
Jun 24, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like, is working fine.
Also linked to SwaySwap and cross-project link is working
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
chore: revert linking changes
Reverts some changes we did in #246 to support linking to SwaySwap when it was using Yarn. It's using PNPM too now so this shouldn't be a problem.
This fixes the VSC issue where changes in one package wasn't reflected on its dependents. You also don't have to run
build:watch
anymore, but certain things might still require you to runpnpm build
.I've been working with this change on my local for a week and it was a great DX improvement.
chore: fix test launch config
Fixes debugging tests using the "Testing" pane of VSC not working.
chore: simplify contract package .gitignore
chore: cleanup
Some cleanups.