Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Functions return random bytes during External execution #5876

Closed
SwayStar123 opened this issue Apr 18, 2024 · 0 comments · Fixed by #5927
Closed

Functions return random bytes during External execution #5876

SwayStar123 opened this issue Apr 18, 2024 · 0 comments · Fixed by #5927
Assignees
@xunilrj @vaivaswatha
Labels
ABI Everything to do the ABI, especially the JSON representation bug Something isn't working P: critical Should be looked at before anything else

Comments

@SwayStar123
Copy link
Member

minimum reproduction https://github.com/SwayStar123/testing_proj/

When an abi function is called through run_external, despite the function being called doing nothing other than returning a hardcoded b256 value, the returned values are random bytes instead
@IGI-111 IGI-111 added bug Something isn't working ABI Everything to do the ABI, especially the JSON representation P: critical Should be looked at before anything else labels Apr 18, 2024
@vaivaswatha vaivaswatha mentioned this issue Apr 26, 2024
Merged
vaivaswatha added a commit that referenced this issue May 6, 2024
@vaivaswatha @JoshuaBatty
Fixes to accessing the data section during bytecode gen (#5927)
20b8ff0 
## Description

This PR fixes a bunch of issues we had in generating access to the data
section. It also fixes #5876.

Reverts #5918.

---------

Co-authored-by: Joshua Batty <joshpbatty@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xunilrj xunilrj

@vaivaswatha vaivaswatha

Labels
ABI Everything to do the ABI, especially the JSON representation bug Something isn't working P: critical Should be looked at before anything else
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes to accessing the data section during bytecode gen FuelLabs/sway
4 participants
@xunilrj @vaivaswatha @IGI-111 @SwayStar123