Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disabling run_external #5918

Merged
merged 2 commits into from
Apr 25, 2024
Merged

Disabling run_external #5918

merged 2 commits into from
Apr 25, 2024

Conversation

xunilrj
Copy link
Contributor

@xunilrj xunilrj commented Apr 25, 2024 •
edited
Loading

Description

This PR removes run_external temporarily until it is stabilized.

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@xunilrj xunilrj self-assigned this Apr 25, 2024
@xunilrj xunilrj requested review from IGI-111 and a team April 25, 2024 18:57
@IGI-111 IGI-111 merged commit 8436a63 into master Apr 25, 2024
35 checks passed
@IGI-111 IGI-111 deleted the xunilrj/disable-run-external branch April 25, 2024 19:46
vaivaswatha added a commit that referenced this pull request Apr 26, 2024
@vaivaswatha
Revert "Disabling run_external (#5918)"
65bc62c 
This reverts commit 8436a63.
@vaivaswatha vaivaswatha mentioned this pull request Apr 26, 2024
Merged
vaivaswatha added a commit that referenced this pull request May 6, 2024
@vaivaswatha @JoshuaBatty
Fixes to accessing the data section during bytecode gen (#5927)
20b8ff0 
## Description

This PR fixes a bunch of issues we had in generating access to the data
section. It also fixes #5876.

Reverts #5918.

---------

Co-authored-by: Joshua Batty <joshpbatty@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ironcev ironcev ironcev approved these changes

@IGI-111 IGI-111 IGI-111 approved these changes

Assignees

@xunilrj xunilrj

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xunilrj @ironcev @IGI-111