Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding subsection on address and contract types #4479

Merged
merged 2 commits into from
Apr 20, 2023
Merged

Adding subsection on address and contract types #4479

merged 2 commits into from
Apr 20, 2023

Conversation

calldelegation
Copy link
Contributor

@calldelegation calldelegation commented Apr 20, 2023 •
edited
Loading

Description

Closes #2704

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@kayagokalp kayagokalp added documentation The Sway Book Everything to do with the Sway Book labels Apr 20, 2023
kayagokalp
kayagokalp approved these changes Apr 20, 2023
View reviewed changes
Copy link
Member

@kayagokalp kayagokalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@mohammadfawaz mohammadfawaz merged commit 3ffd038 into master Apr 20, 2023
25 checks passed
@mohammadfawaz mohammadfawaz deleted the add/solidity-account-differences branch April 20, 2023 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kayagokalp kayagokalp kayagokalp approved these changes

@mohammadfawaz mohammadfawaz mohammadfawaz approved these changes

@matt-user matt-user Awaiting requested review from matt-user

Assignees

@calldelegation calldelegation

Labels
documentation The Sway Book Everything to do with the Sway Book
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

docs: add information about Address and ContractId types to the Differences from Solidity section
3 participants
@calldelegation @kayagokalp @mohammadfawaz