Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stabilize module privacy #4574

Merged
merged 1 commit into from
May 25, 2023
Merged

Stabilize module privacy #4574

merged 1 commit into from
May 25, 2023

Conversation

IGI-111
Copy link
Contributor

@IGI-111 IGI-111 commented May 22, 2023

Description

Set experimental module privacy rules as the default and remove the experimental flag.
Closes #4506

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@IGI-111 IGI-111 added breaking May cause existing user code to break. Requires a minor or major release. compiler: ui Mostly compiler messages labels May 22, 2023
@IGI-111 IGI-111 self-assigned this May 22, 2023
@IGI-111 IGI-111 requested a review from a team May 23, 2023 12:11
@IGI-111 IGI-111 marked this pull request as ready for review May 23, 2023 12:12
tritao
tritao previously approved these changes May 23, 2023
@IGI-111 IGI-111 requested a review from a team May 23, 2023 12:21
esdrubal
esdrubal previously approved these changes May 23, 2023
@IGI-111 IGI-111 dismissed stale reviews from esdrubal and tritao via 1fff983 May 25, 2023 07:00
Set experimental module privacy rules as the default and remove the
experimental flag.
@IGI-111 IGI-111 force-pushed the IGI-111/stabilize-module-privacy branch from 1fff983 to 0999056 Compare May 25, 2023 07:03
@IGI-111 IGI-111 requested review from tritao and esdrubal May 25, 2023 07:03
@IGI-111 IGI-111 merged commit 161ae35 into master May 25, 2023
26 checks passed
@IGI-111 IGI-111 deleted the IGI-111/stabilize-module-privacy branch May 25, 2023 09:25
@kayagokalp kayagokalp mentioned this pull request May 30, 2023
7 tasks
IGI-111 added a commit that referenced this pull request May 31, 2023
## Description

Waiting for:
- #4525.

@Dhaiwat10 was waiting for a release with the linked PR merged.

@IGI-111 I had the PR ready, leaving it up to you when to merge & cut
the release. Made this a major bump as we had a breaking change merged
(#4574).

## Checklist

- [ ] I have linked to any relevant issues.
- [ ] I have commented my code, particularly in hard-to-understand
areas.
- [ ] I have updated the documentation where relevant (API docs, the
reference, and the Sway book).
- [ ] I have added tests that prove my fix is effective or that my
feature works.
- [ ] I have added (or requested a maintainer to add) the necessary
`Breaking*` or `New Feature` labels where relevant.
- [ ] I have done my best to ensure that my PR adheres to [the Fuel Labs
Code Review
Standards](https://github.com/FuelLabs/rfcs/blob/master/text/code-standards/external-contributors.md).
- [ ] I have requested a review from the relevant team or maintainers.

Co-authored-by: IGI-111 <igi-111@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking May cause existing user code to break. Requires a minor or major release. compiler: ui Mostly compiler messages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove experimental flag for module privacy
3 participants