Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove experimental flag for module privacy #4506

Closed
IGI-111 opened this issue Apr 28, 2023 · 0 comments · Fixed by #4574
Closed

Remove experimental flag for module privacy #4506

IGI-111 opened this issue Apr 28, 2023 · 0 comments · Fixed by #4574
Labels
breaking May cause existing user code to break. Requires a minor or major release. compiler: frontend Everything to do with type checking, control flow analysis, and everything between parsing and IRgen compiler: ui Mostly compiler messages

Comments

@IGI-111
Copy link
Contributor

IGI-111 commented Apr 28, 2023

Since module privacy has been merged and should be released in 0.9.0, we should leave at least one major release for the users to migrate their codebase and remove the flag to make the experimental behavior the default
@IGI-111 IGI-111 added breaking May cause existing user code to break. Requires a minor or major release. compiler: frontend Everything to do with type checking, control flow analysis, and everything between parsing and IRgen compiler: ui Mostly compiler messages labels Apr 28, 2023
@IGI-111 IGI-111 mentioned this issue Apr 28, 2023
Closed
3 tasks
@IGI-111 IGI-111 mentioned this issue May 22, 2023
Merged
7 tasks
IGI-111 added a commit that referenced this issue May 25, 2023
@IGI-111
Stabilize module privacy (#4574)
161ae35 
## Description

Set experimental module privacy rules as the default and remove the
experimental flag.
Closes #4506 

## Checklist

- [x] I have linked to any relevant issues.
- [x] I have commented my code, particularly in hard-to-understand
areas.
- [x] I have updated the documentation where relevant (API docs, the
reference, and the Sway book).
- [x] I have added tests that prove my fix is effective or that my
feature works.
- [x] I have added (or requested a maintainer to add) the necessary
`Breaking*` or `New Feature` labels where relevant.
- [x] I have done my best to ensure that my PR adheres to [the Fuel Labs
Code Review
Standards](https://github.com/FuelLabs/rfcs/blob/master/text/code-standards/external-contributors.md).
- [x] I have requested a review from the relevant team or maintainers.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking May cause existing user code to break. Requires a minor or major release. compiler: frontend Everything to do with type checking, control flow analysis, and everything between parsing and IRgen compiler: ui Mostly compiler messages
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Stabilize module privacy FuelLabs/sway
1 participant
@IGI-111