Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Also test on Julia v1.2, switch from REQUIRE to Project.toml, increase version #50

Merged
merged 3 commits into from
Jun 3, 2019

Conversation

oschulz
Copy link
Contributor

@oschulz oschulz commented May 31, 2019

This enables testing on Julia v1.2 (works now, see #48) and gets TypedTables ready for Registrator.

@andyferris , if this goes through CI, would you consider a timely release (hard to test some of my packages on Julia v1.2-RC1 without TypedTables)?

The last commit increases the version of TypedTables to v1.2.0 - is this fine? Or should it be v1.1.1?

* [compat] section is required now. Require Julia v1
* Current version of package is actually 1.1.0
@coveralls
Copy link

coveralls commented May 31, 2019

Coverage Status

Coverage remained the same at 67.974% when pulling 5164965 on oschulz:julia12-ci into 97fd36e on FugroRoames:master.

@codecov-io
Copy link

codecov-io commented May 31, 2019

Codecov Report

Merging #50 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #50   +/-   ##
=======================================
  Coverage   67.06%   67.06%           
=======================================
  Files           6        6           
  Lines         498      498           
=======================================
  Hits          334      334           
  Misses        164      164

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 97fd36e...5164965. Read the comment docs.

@oschulz
Copy link
Contributor Author

oschulz commented May 31, 2019

Looks like Travis still has trouble installing Julia 1.2 on Linux

Notable changes compared to v1.1.0:

* Requires Julia v1.x
* Project.toml only, no REQUIRE
* Julia v1.2 compatible.
@oschulz
Copy link
Contributor Author

oschulz commented Jun 1, 2019

Looks like Travis still has trouble installing Julia 1.2 on Linux

Ok, looks good now @andyferris .

@andyferris andyferris merged commit 59773eb into JuliaData:master Jun 3, 2019
@andyferris
Copy link
Member

Thanks @oschulz!

would you consider a timely release

Yes let's do that. Sorry been busy over the weekend.

@oschulz
Copy link
Contributor Author

oschulz commented Jun 3, 2019

No worries - thanks for the quick merge!

@oschulz
Copy link
Contributor Author

oschulz commented Jun 3, 2019

@andyferris , Registrator doesn't seem to have picked up the new release (at least there's no PR on the general registry).

@oschulz
Copy link
Contributor Author

oschulz commented Jun 13, 2019

Hey @andyferris , something seems to have gone wrong with the release, TypedTables in still on v1.1.0 in the Julia registry. Could you take a look? Sorry to bother you, it's just that this is blocking Travis/Appveyor testing on Julia v1.2 for some of my packages that use TypedTables.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants