Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding missing constraints to parameterisations #3112

Open
kj5248 opened this issue Mar 19, 2024 · 0 comments
Open

Adding missing constraints to parameterisations #3112

kj5248 opened this issue Mar 19, 2024 · 0 comments
Labels
geometry Tasks relating to the geometry module

Comments

@kj5248
Copy link
Contributor

kj5248 commented Mar 19, 2024

Description of issue / requirement to address

Came around from issue #727. Sometimes the optimisation can result in odd shapes due to the lack of constraints on certain parameterisations such as the PictureFrame. Currently PrinctonD, TripleArc and SextupleArc have contraints whilst PolySpline and PictureFrame do not. Needs to be decided for each class whether a constraint is necessary and if so adding one. It would be necessary to add one if the parameterisation class is often used with unfixed variables.

Related file is bluemira/geometry/parameterisations.py

Additional work on constraints

For classes with a constraint a check of the produced shape could be performed within the create_shape function of each class to check violation of the class constraints.

@kj5248 kj5248 added the geometry Tasks relating to the geometry module label Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
geometry Tasks relating to the geometry module
Projects
None yet
Development

No branches or pull requests

1 participant