Tag flexibility #801
Merged
Tag flexibility #801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
please do not merge yet |
|
This would be it for the moment, please leave your comments |
achilleas-k
approved these changes
Nov 29, 2019
There was a problem hiding this comment.
I compiled the following tables from the data access test for Tag while reviewing and thought it might be useful to have associated with the PR.
Data dimensionality and sampling interval:
| 1D | 2D | 3D | |
|---|---|---|---|
| Dimensionality | 100 | 100, 10 | 100, 10, 5 |
| Sampling (first dim only) | 0.1 | 1.0 | 1.0 |
Tag data retrieval
| Position | Extent | Data 1D | Data 2D | Data 3D |
|---|---|---|---|---|
| 25, 0 | 50, 5 | 501 | 51, 6 | 51, 6, 5 |
| 25, 0, 0 | None | 1 | 1, 1 | 1, 1, 1 |
| 25, 0, 0 | 0, 0, 0 | 1 | 1, 1 | 1, 1, 1 |
| 25, 0, 0 | 0, 0 | Error | Error | Error |
So as discussed, the data access rules now are:
- Length of Position and Extent arrays should still match.
- Extra dimensions in Pos and Ext wrt DataArray are ignored (e.g., 3 pos on 2D array).
- Missing dimensions in Pos and Ext wrt DataArray are considered "full slice" (e.g., 2 pos on 3D array).
- Zeroes in Ext are equivalent to no Ext.
| auto extSize = extents.size(); | ||
| auto it = refs.begin(); | ||
| while (!mismatch && (it != refs.end())) { | ||
| auto arrayExtent = (*it).dataExtent(); | ||
| mismatch = extSize != arrayExtent.size(); | ||
| ++it; | ||
| } | ||
|
|
||
| */ |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addresses #800 but only for 1.4