-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tag flexibility #805
Tag flexibility #805
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this is identical to the last merged PR, I'm approving without going through the diff line-by-line.
Now there are merge conflicts and the new |
Codecov Report
@@ Coverage Diff @@
## master #805 +/- ##
==========================================
+ Coverage 94.66% 94.71% +0.05%
==========================================
Files 177 179 +2
Lines 12385 12540 +155
==========================================
+ Hits 11724 11877 +153
- Misses 661 663 +2
Continue to review full report at Codecov.
|
faac8b3
to
899ca95
Compare
we do not require that any more, it is fine to provide less information, the present info, however must match, therefore the check for present units was extended
@achilleas-k @gicmo, I guess I am done with it for now (if the checks pass) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small comment.
Is this good to go? |
I managed to review the code, and that is fine, I have not yet a chance to think through what it actually does. I try again tonight or will default to 'yes' ;) |
companion to #801 but for master branch