Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tag flexibility #805

Merged
merged 20 commits into from
Apr 12, 2020
Merged

Tag flexibility #805

merged 20 commits into from
Apr 12, 2020

Conversation

jgrewe
Copy link
Member

@jgrewe jgrewe commented Mar 17, 2020

companion to #801 but for master branch

Copy link
Member

@achilleas-k achilleas-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is identical to the last merged PR, I'm approving without going through the diff line-by-line.

src/valid/checks.cpp Outdated Show resolved Hide resolved
@gicmo
Copy link
Member

gicmo commented Apr 4, 2020

Now there are merge conflicts and the new DataFrameDimension is missing everywhere ;P

@codecov
Copy link

codecov bot commented Apr 4, 2020

Codecov Report

Merging #805 into master will increase coverage by 0.05%.
The diff coverage is 96.98%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #805      +/-   ##
==========================================
+ Coverage   94.66%   94.71%   +0.05%     
==========================================
  Files         177      179       +2     
  Lines       12385    12540     +155     
==========================================
+ Hits        11724    11877     +153     
- Misses        661      663       +2     
Impacted Files Coverage Δ
src/valid/checks.cpp 93.10% <90.90%> (-3.49%) ⬇️
src/util/dataAccess.cpp 91.31% <93.10%> (+1.28%) ⬆️
test/TestDataType.cpp 95.83% <95.83%> (ø)
include/nix/valid/checks.hpp 100.00% <100.00%> (ø)
src/valid/helper.cpp 100.00% <100.00%> (+8.33%) ⬆️
src/valid/validate.cpp 76.84% <100.00%> (+1.61%) ⬆️
test/BaseTestDataAccess.cpp 100.00% <100.00%> (ø)
test/Runner.cpp 100.00% <100.00%> (ø)
test/TestDataType.hpp 100.00% <100.00%> (ø)
test/TestValidate.cpp 98.15% <100.00%> (-0.10%) ⬇️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c1fbfbf...a7d7fd9. Read the comment docs.

@jgrewe jgrewe force-pushed the tag_flexibility branch 5 times, most recently from faac8b3 to 899ca95 Compare April 5, 2020 20:13
src/util/dataAccess.cpp Outdated Show resolved Hide resolved
@jgrewe
Copy link
Member Author

jgrewe commented Apr 6, 2020

@achilleas-k @gicmo, I guess I am done with it for now (if the checks pass)

Copy link
Member

@achilleas-k achilleas-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small comment.

test/TestDataType.cpp Outdated Show resolved Hide resolved
@achilleas-k
Copy link
Member

Is this good to go?

@gicmo
Copy link
Member

gicmo commented Apr 8, 2020

Is this good to go?

I managed to review the code, and that is fine, I have not yet a chance to think through what it actually does. I try again tonight or will default to 'yes' ;)

src/util/dataAccess.cpp Outdated Show resolved Hide resolved
@gicmo gicmo merged commit fd22ba0 into G-Node:master Apr 12, 2020
@jgrewe jgrewe deleted the tag_flexibility branch April 12, 2020 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants