Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposed 'tools' module restructuring #333

Closed
mpsonntag opened this issue Nov 6, 2019 · 2 comments
Closed

Proposed 'tools' module restructuring #333

mpsonntag opened this issue Nov 6, 2019 · 2 comments

Comments

@mpsonntag
Copy link
Contributor

The current tools module structure does not allow to put classes at the module level to make them easier to import and use. See #317. Linking the FormatConverter or the VersionConverter class, currently leads to an import cycle.

By creating a submodule odml.tools.converters and move both format_converter.py and version_converter.py into the new submodule the described import cycle can be avoided and all Parser and Converter classes can be made available via the respective __init__.py files.

@mpsonntag
Copy link
Contributor Author

As an additional note: this change of structure will lead to a required update of odml-ui since it is importing the VersionConverter.

@mpsonntag
Copy link
Contributor Author

Closed via PR #342

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant