Improve M4A file upload detection #1115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexgao1
requested changes
Feb 1, 2023
...couch-onUpload/src/main/java/ca/carleton/gcrc/couch/onUpload/parser/ContentTypeDetector.java
Outdated
Show resolved
Hide resolved
|
Changes made look good, m4a files worked |
…pload-m4a-file-multimedia
alexgao1
reviewed
Feb 1, 2023
...iit2-multimedia/src/main/java/ca/carleton/gcrc/olkit/multimedia/ffmpeg/FFprobeProcessor.java
Outdated
Show resolved
Hide resolved
added 2 commits
February 1, 2023 11:37
…pload-m4a-file-multimedia
billingb
reviewed
Feb 1, 2023
|
|
||
| public class FileStream { | ||
|
|
||
| public String codecType; |
| JSONArray streams = json.getJSONArray("streams"); | ||
|
|
||
| List<FileStream> fileStreams = new ArrayList<FileStream>(); | ||
| for (int i = 0; i < streams.length(); i++) { |
There was a problem hiding this comment.
Could consider using streams, would make it cleaner IMO but not a big deal if you prefer this appraoch.
There was a problem hiding this comment.
added 3 commits
February 3, 2023 12:54
…pload-m4a-file-multimedia
alexgao1
changed the title
alexgao1
pushed a commit
that referenced
this pull request
Feb 7, 2023
* fix the issue with .m4a file upload * fix issue with .m4a file upload * check media stream if the file has audio//video streams * fix logs * fix the code reviews comments * code refactor --------- Co-authored-by: Nunaliit <nunaliit@lunageo-asus> Co-authored-by: Jagdish Kunwar <jkunawr@lunageo.com> Co-authored-by: Jagdish Kunwar <jkunwar@luageo.com>
alexgao1
added a commit
that referenced
this pull request
Feb 7, 2023
* fix the issue with .m4a file upload * fix issue with .m4a file upload * check media stream if the file has audio//video streams * fix logs * fix the code reviews comments * code refactor --------- Co-authored-by: kunwarj <121902036+kunwarj@users.noreply.github.com> Co-authored-by: Nunaliit <nunaliit@lunageo-asus> Co-authored-by: Jagdish Kunwar <jkunawr@lunageo.com> Co-authored-by: Jagdish Kunwar <jkunwar@luageo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix checks for the media streams of audio or video files after getting the MIME type from Tika library. If the streams has only one stream and its codec type is audio then it treats as audio, else if multiple streams with video codec type, then is treats as video.