-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Add process number to tables #10763
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10763 +/- ##
============================================
- Coverage 38.28% 38.27% -0.02%
- Complexity 1652 1654 +2
============================================
Files 1021 1021
Lines 31191 31221 +30
Branches 6509 6523 +14
============================================
+ Hits 11943 11951 +8
- Misses 19081 19236 +155
+ Partials 167 34 -133
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@brindasasi Gray said it's supposed to be a separate column. Should have it finished tomorrow for another review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Sorry, missed the discussion about separate columns.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Took a look
One insignificant typo, one question, and one thing to definitely check on
apps/web/src/components/PoolCandidatesTable/PoolCandidatesTable.tsx
Outdated
Show resolved
Hide resolved
apps/web/src/components/PoolCandidatesTable/PoolCandidatesTable.tsx
Outdated
Show resolved
Hide resolved
@vd1992 @brindasasi @petertgiles Ready for a review now 😆 whoever wants to jump on it first Oh nvm Vachan got to it! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, looks great!
🤖 Resolves #10695
👋 Introduction
🧪 Testing
Assist reviewers with steps they can take to test that the PR does what it says it does.
admin@test.com
📸 Screenshot