Skip to content
This repository has been archived by the owner on Oct 26, 2021. It is now read-only.

meta-iot-web: Add new layer for iotivity-node support #58 (reopen) #61

Merged
merged 1 commit into from Mar 2, 2017

Conversation

rzr
Copy link
Contributor

@rzr rzr commented Feb 17, 2017

This is following instructions given at:
#58

One merged please merge:
GENIVI/meta-genivi-dev#63

@rzr rzr closed this Feb 17, 2017
@rzr rzr reopened this Feb 17, 2017
@rzr rzr force-pushed the sandbox/pcoval/on/master/review branch 2 times, most recently from 6deaf8f to 1c53692 Compare February 17, 2017 14:16
@rzr rzr changed the title Sandbox/pcoval/on/master/review meta-iot-web: Add new layer for iotivity-node support #58 (reopen) Feb 17, 2017
IoTivity NodeJS bindings ease development of IoT projects.
For more tips and details about using this, please check:
https://wiki.iotivity.org/automotive .

Current version is supporting IoTivity 1.2.0 from meta-oic.

[GDP-160] meta-genivi-ocf-demo merging

Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
@rzr rzr force-pushed the sandbox/pcoval/on/master/review branch from 1c53692 to e600b53 Compare February 17, 2017 14:40
Copy link
Contributor

@chbae chbae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for me. Then how can I test this?

@rzr
Copy link
Contributor Author

rzr commented Feb 18, 2017

There are a few example in the package, check also:
https://wiki.iotivity.org/automotive#work_in_progress

@rzr
Copy link
Contributor Author

rzr commented Feb 22, 2017

Any idea what's wrong with porter board ? I need a login to view the log.

cc: @zeenix @ns950

@gunnarx
Copy link
Member

gunnarx commented Feb 22, 2017

@rzr Don't worry - Porter is currently failing also on master branch so it should have nothing to do with your PR. As soon as it is fixed, the check will rebuild and turn green (unless we merge it before then anyhow)

@slawr
Copy link
Member

slawr commented Feb 23, 2017

@rzr Hi Phil I had a look at the log for the PR. It is failing for the same reason that master is failing - no one providing libgudev since a change in the GDP image packages. I'll be fixing that once I've pushed a GDP PR I'm preparing. It's at do_rootfs() time so very late in the build process. I'm not a GDP maintainer and of course there is a small chance that adding your layer might go onto throw its own do_rootfs() task error, but that seems remote. So like Gunnar I would expect this PR is ok.

p.s. It's straight forward to get a go.cd login. You just need a ssh key. I can't remember the exact process. I think Gunnar documented it, although I'm sure he would help.

@rzr
Copy link
Contributor Author

rzr commented Feb 23, 2017

Ok thank @slawr for keeping us informed about the state of master branch.

@zeenix is there a bug to track about this ?

To help, I can double check fixes if any.

@zeenix
Copy link
Contributor

zeenix commented Feb 23, 2017

@slawr
Copy link
Member

slawr commented Feb 27, 2017

I've started to look at GDP-561. Updating there.

@gunnarx
Copy link
Member

gunnarx commented Mar 1, 2017

Adding my +1 which I missed before. Were you waiting for me? I don't see anything blocking this. We're all convinced GDP-561 is causing the check failure. All other checks are OK.
What is holding it up now?

@zeenix
Copy link
Contributor

zeenix commented Mar 2, 2017

I hadn't merged yet cause I was hoping @chbae will provide feedback from his testing since he asked for how to test this all. But yeah, this is just adding the layer so let's merge this at least first.

@zeenix zeenix merged commit b7c93e7 into GENIVI:master Mar 2, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
5 participants