-
Notifications
You must be signed in to change notification settings - Fork 79
meta-iot-web: Add new layer for iotivity-node support #58 (reopen) #61
meta-iot-web: Add new layer for iotivity-node support #58 (reopen) #61
Conversation
6deaf8f
to
1c53692
Compare
IoTivity NodeJS bindings ease development of IoT projects. For more tips and details about using this, please check: https://wiki.iotivity.org/automotive . Current version is supporting IoTivity 1.2.0 from meta-oic. [GDP-160] meta-genivi-ocf-demo merging Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
1c53692
to
e600b53
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good for me. Then how can I test this?
There are a few example in the package, check also: |
@rzr Don't worry - Porter is currently failing also on master branch so it should have nothing to do with your PR. As soon as it is fixed, the check will rebuild and turn green (unless we merge it before then anyhow) |
@rzr Hi Phil I had a look at the log for the PR. It is failing for the same reason that master is failing - no one providing libgudev since a change in the GDP image packages. I'll be fixing that once I've pushed a GDP PR I'm preparing. It's at do_rootfs() time so very late in the build process. I'm not a GDP maintainer and of course there is a small chance that adding your layer might go onto throw its own do_rootfs() task error, but that seems remote. So like Gunnar I would expect this PR is ok. p.s. It's straight forward to get a go.cd login. You just need a ssh key. I can't remember the exact process. I think Gunnar documented it, although I'm sure he would help. |
I've started to look at GDP-561. Updating there. |
Adding my +1 which I missed before. Were you waiting for me? I don't see anything blocking this. We're all convinced GDP-561 is causing the check failure. All other checks are OK. |
I hadn't merged yet cause I was hoping @chbae will provide feedback from his testing since he asked for how to test this all. But yeah, this is just adding the layer so let's merge this at least first. |
This is following instructions given at:
#58
One merged please merge:
GENIVI/meta-genivi-dev#63