Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mapp.ui.layers.panels.style composition #1154

Closed
dbauszus-glx opened this issue Feb 23, 2024 · 2 comments · Fixed by #1431
Closed

mapp.ui.layers.panels.style composition #1154

dbauszus-glx opened this issue Feb 23, 2024 · 2 comments · Fixed by #1431
Assignees
Labels
Bug A genuine bug. There must be some form of error exception to work with. Feature New feature requests or changes to the behaviour or look of existing application features. RFC Request for Comment or Change.

Comments

@dbauszus-glx
Copy link
Member

The style panel module creates a drawer with a legend and supporting style elements for hover and label. Changing the theme will reload the panel.

It should be possible to have the legend from the theme with the label and hover control outside the style panel.

A method to construct the style view with selected elements should be available to be called from the panel.

@dbauszus-glx dbauszus-glx added the Bug A genuine bug. There must be some form of error exception to work with. label Feb 23, 2024
@dbauszus-glx dbauszus-glx added the RFC Request for Comment or Change. label Mar 15, 2024
@cityremade cityremade added this to the UI Elements milestone May 8, 2024
@dbauszus-glx
Copy link
Member Author

#1362 must be merged before this can be addressed.

@simon-leech
Copy link
Contributor

When using a categorized thematic with fields array - the switch-all text is not applied. This is correct as switch-all cannot work.
However, there should be a default applied for the user.

We need to ensure we test theme.meta.

@dbauszus-glx dbauszus-glx added the Feature New feature requests or changes to the behaviour or look of existing application features. label Aug 22, 2024
@dbauszus-glx dbauszus-glx self-assigned this Aug 22, 2024
@dbauszus-glx dbauszus-glx linked a pull request Aug 22, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug A genuine bug. There must be some form of error exception to work with. Feature New feature requests or changes to the behaviour or look of existing application features. RFC Request for Comment or Change.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants