[Feature] Support for .netcore 2.0

[SergiusZurawski]

Is there a chance this project will be ported to Dotnet Core 2.0 ?

[elv1s42]

Hi @SergiusZurawski !

Thank you for this issue. I agree that it would be useful.
Putting 'enhancement' label to resolve it in the future.

[Rogitel]

Any update on this? I love this tool, want to continue using it...

[elv1s42]

Hi @Rogitel !
Sure, I'll try to include this in the release v0.9.5, not in the next one.

Can you please tell me which framework are you using with Ghpr.Core (SpecFlow, MSTest, NUnit)?
We should also update corresponding projects to .netcore 2.0.

Thank you

[elv1s42]

@SergiusZurawski , if possible, can you also please tell me which framework are you using with Ghpr.Core (SpecFlow, MSTest, NUnit)?

[Rogitel]

That would be great! I've been using NUnit.

[jmemmons]

Hey @elv1s42, can I go ahead and do this or have you already started?

[elv1s42]

Hi @jmemmons,
Sorry for the late response, for some reason I stoped receiving notification emails about the issue.

I didn't start implementation becuase I don't have much time to work on it and this issue is actually quite a big piece of work. There are some open questions around it like "Should we create a separate solution?", "How to run tests for .NET Core project?", "How do we reuse code?", "How to release mutilple versions?" etc

I think we should try re-use existing classes and add try to them as links to .NET Core project.
Also we will have to review AppVeyor file to build, run tests and publish mutliple solutions.

[jmemmons]

I went ahead and started porting the code to .NET Core 2.1 in my forked repository to get an idea of what needs to happen.

I created another project called "Ghpr.Core.NetCore" in the same solution and added a new build configuration for .NET 4.7.2 called "Release-NET47". The projects can live together in the same solution which should make development easier.

The only class that gave me issues was ScreenshotHelper which uses a library that's not available in .NET Core (System.Drawing). I also had trouble with the embedded resources but I wasn't able to spend much time with it. I'd suggest the first thing we do is to port the tests over first so we have a base regression suite we can use to verify that code is not broken during this process.

[elv1s42]

Released.
Please feel free to reopen this one a raise a new issue in case something is not working.