Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Header and Payload #15

Open
lccodes opened this issue Feb 8, 2018 · 0 comments
Open

Header and Payload #15

lccodes opened this issue Feb 8, 2018 · 0 comments

Comments

@lccodes
Copy link
Contributor

lccodes commented Feb 8, 2018

class BasicHeader implements Header {

The Header classes and Payload classes should be better in sync, potentially also with signature functionality, and have a clearer hierarchy. It's hard to tell the difference between header's various types and payload's various types.

A better class hierarchy should help answer the question of where various payload and header functionality should live.

Also, everything under an "impl" file is difficult to comprehend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant