Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed cache deletion code #1824

Merged
merged 1 commit into from Dec 11, 2017
Merged

fixed cache deletion code #1824

merged 1 commit into from Dec 11, 2017

Conversation

nathandunn
Copy link
Contributor

Fixes #1832

@nathandunn nathandunn added this to the 2.0.9 milestone Dec 11, 2017
@nathandunn nathandunn self-assigned this Dec 11, 2017
@ghost ghost added the in progress label Dec 11, 2017
@nathandunn
Copy link
Contributor Author

@deepakunni3 Can you review this when you have a moment. I've tested it and it works. Just a visual sanity check would be useful. Thanks.

@nathandunn
Copy link
Contributor Author

@deepakunni3 I'm going to go ahead and merge this because I want to get the correct code into the AGR production site (I think the cache is obsolete). Let me know if you see anything weird, though.

@nathandunn nathandunn merged commit 51fc14c into GMOD:master Dec 11, 2017
@ghost ghost removed the in progress label Dec 11, 2017
@deepakunni3
Copy link
Member

deepakunni3 commented Dec 11, 2017 •
edited

@nathandunn Looks good

@nathandunn nathandunn mentioned this pull request Dec 19, 2017
Closed
@nathandunn nathandunn modified the milestones: 2.0.9, 2.1.0 Jun 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepakunni3 deepakunni3 Awaiting requested review from deepakunni3

Assignees

@nathandunn nathandunn

Labels
None yet
Projects
None yet
Milestone
2.1.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nathandunn @deepakunni3