Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove annotation popups #2335

Merged
merged 52 commits into from
Dec 11, 2019
Merged

remove annotation popups #2335

merged 52 commits into from
Dec 11, 2019

Conversation

nathandunn
Copy link
Contributor

@nathandunn nathandunn commented Dec 4, 2019

fixes #2334

  • viewing info editor should open the side-panel
  • add a close annotator panel to menu with shortcut
  • cleanup
  • add statuses to details
    • get available statuses
    • read in set status
    • allow update of status to any value including null
    • hide if none available
    • put in transcript, non-coding, variant, ??
  • fix bug with variant
  • redo REST doc
  • Alt-click should go to ‘view in annotator panel’
  • remove from interfaces
  • add should use Canned Comment list box, replace and add service from getAnnotationInfoEditor

===

  • add should use Canned Comment with a suggest lookup
  • Attributes should use lookup values:
    • wire in new method for attribute / values
    • on selection, add to box
    • wire in old method for loading
  • add Attributes
    • load existing
    • duplicate add panel
    • duplicate remove panel
    • edit update panel
  • add comments
    • load existing
    • duplicate add panel
    • duplicate remove panel
    • edit update panel
  • on clicking alternate annotations, should reload comments, dbxrefs, attributes
  • update using AEC/updateDbXref
  • add more room for details view
  • add created date and last modified date to details
  • add DbXref
    • add using AEC/addDbXref
    • add using AEC/deleteDbXref
    • revert on error
    • sort on update so always consistent
    • add PubMedIds as a special case that we check
    • do check for valid PMID via proxyservice
    • add ScrollPanel
    • remove PubMedPanel

@nathandunn nathandunn added this to In progress in 2.6.0 LTS via automation Dec 4, 2019
@nathandunn nathandunn changed the title added more fields remove annotation popups Dec 4, 2019
@nathandunn nathandunn merged commit 3c0b6e2 into develop Dec 11, 2019
2.6.0 LTS automation moved this from In progress to Done Dec 11, 2019
@cmdcolin cmdcolin deleted the fix-2334 branch December 7, 2023 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
2.6.0 LTS
  
Done
Development

Successfully merging this pull request may close these issues.

remove popups for annotations
1 participant