Fix auto-updates on desktop not working since v2.2.2 (#3451)

GMOD · Jan 11, 2023 · 0de6e62 · 0de6e62
1 parent 5c51bd4
commit 0de6e62
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 7 deletions.
diff --git a/products/jbrowse-desktop/package.json b/products/jbrowse-desktop/package.json
@@ -13,8 +13,8 @@
     "electron": "electron .",
     "test": "craco test",
     "electron-ts": "yarn tsc --strict --esModuleInterop --skipLibCheck public/electron.ts",
+    "preelectron": "npm run electron-ts",
     "prebuild": "npm run electron-ts",
-    "predevelop": "npm run electron-ts",
     "prepack": "yarn build",
     "build": "craco build",
     "build-electron": "yarn build && electron-builder build --windows --mac --linux",

diff --git a/products/jbrowse-desktop/public/electron.ts b/products/jbrowse-desktop/public/electron.ts
@@ -208,6 +208,14 @@ async function createWindow() {
     },
   })
   mainWindowState.manage(mainWindow)
+
+  // this ready-to-show handler must be attached before the loadURL
+  mainWindow.once('ready-to-show', () => {
+    // unsure how to error handle
+    // eslint-disable-next-line @typescript-eslint/no-floating-promises
+    autoUpdater.checkForUpdatesAndNotify()
+  })
+
   await mainWindow.loadURL(
     isDev
       ? url.format(devServerUrl)
@@ -331,12 +339,6 @@ async function createWindow() {
   mainWindow.on('closed', () => {
     mainWindow = null
   })
-
-  mainWindow.once('ready-to-show', () => {
-    // unsure how to error handle
-    // eslint-disable-next-line @typescript-eslint/no-floating-promises
-    autoUpdater.checkForUpdatesAndNotify()
-  })
 }
 
 function sendStatusToWindow(text: string) {