[skip ci] Thrown error objects in typescript are unknowns generally i…

…nstead of Error
GMOD · Oct 3, 2023 · 2bf3797 · 2bf3797
1 parent 87daee3
commit 2bf3797
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 10 deletions.
diff --git a/plugins/grid-bookmark/src/GridBookmarkWidget/components/ShareBookmarksDialog.tsx b/plugins/grid-bookmark/src/GridBookmarkWidget/components/ShareBookmarksDialog.tsx
@@ -57,9 +57,7 @@ const ShareBookmarksDialog = observer(function ({
         }
         setLoading(true)
         const snap = getSnapshot(bookmarksToShare)
-
         const locationUrl = new URL(window.location.href)
-
         const result = await shareSessionToDynamo(
           snap,
           session.shareURL,
@@ -75,7 +73,6 @@ const ShareBookmarksDialog = observer(function ({
         }
       } catch (e) {
         setError(e)
-        session.notify(`${e}`, 'error')
       } finally {
         setLoading(false)
       }

diff --git a/plugins/linear-genome-view/src/LinearGenomeView/model.ts b/plugins/linear-genome-view/src/LinearGenomeView/model.ts
@@ -242,7 +242,7 @@ export function stateModelFactory(pluginManager: PluginManager) {
       volatileWidth: undefined as number | undefined,
       minimumBlockWidth: 3,
       draggingTrackId: undefined as undefined | string,
-      volatileError: undefined as undefined | Error,
+      volatileError: undefined as unknown,
 
       // array of callbacks to run after the next set of the displayedRegions,
       // which is basically like an onLoad
@@ -535,7 +535,7 @@ export function stateModelFactory(pluginManager: PluginManager) {
       /**
        * #action
        */
-      setError(error: Error | undefined) {
+      setError(error: unknown) {
         self.volatileError = error
       },
       /**

diff --git a/products/jbrowse-react-circular-genome-view/src/createModel/createModel.ts b/products/jbrowse-react-circular-genome-view/src/createModel/createModel.ts
@@ -59,7 +59,7 @@ export default function createModel(
       ),
     })
     .volatile(() => ({
-      error: undefined as Error | undefined,
+      error: undefined as unknown,
       adminMode: false,
       version,
     }))
@@ -83,8 +83,8 @@ export default function createModel(
       /**
        * #action
        */
-      setError(errorMessage: Error | undefined) {
-        self.error = errorMessage
+      setError(error: unknown) {
+        self.error = error
       },
       /**
        * #action

diff --git a/products/jbrowse-react-linear-genome-view/src/createModel/createModel.ts b/products/jbrowse-react-linear-genome-view/src/createModel/createModel.ts
@@ -93,8 +93,8 @@ export default function createModel(
       /**
        * #action
        */
-      setError(errorMessage: Error | undefined) {
-        self.error = errorMessage
+      setError(error: unknown) {
+        self.error = error
       },
       /**
        * #action