Fix loading session shares that have a plus sign in the sessionId (#3524

) * Encode the URI component * Fix for older versions by updating lambda code directly
GMOD · Feb 16, 2023 · b645ef1 · b645ef1
1 parent 819526f
commit b645ef1
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/products/jbrowse-aws-lambda-functions/saved-sessions/read-session-jbrowse.js b/products/jbrowse-aws-lambda-functions/saved-sessions/read-session-jbrowse.js
@@ -17,8 +17,12 @@ async function readSession(sessionId) {
 
 exports.handler = async event => {
   const data = event.queryStringParameters
-  const { sessionId } = data
+  let { sessionId } = data
   let tableData
+
+  // workaround for '+' character being encoded by api gateway (?) as space, xref
+  // https://github.com/GMOD/jbrowse-components/pull/3524
+  sessionId = sessionId.replace(/ /g, '+')
   try {
     tableData = await readSession(sessionId)
   } catch (e) {

diff --git a/products/jbrowse-web/src/sessionSharing.ts b/products/jbrowse-web/src/sessionSharing.ts
@@ -72,7 +72,7 @@ export async function readSessionFromDynamo(
   signal?: AbortSignal,
 ) {
   const sessionId = sessionQueryParam.split('share-')[1]
-  const url = `${baseUrl}?sessionId=${sessionId}`
+  const url = `${baseUrl}?sessionId=${encodeURIComponent(sessionId)}`
   const response = await fetch(url, {
     signal,
   })