Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.3.5 not published on npmjs.com #2249

Closed
abretaud opened this issue Aug 24, 2021 · 7 comments
Closed

1.3.5 not published on npmjs.com #2249

abretaud opened this issue Aug 24, 2021 · 7 comments
Labels
bug Something isn't working

Comments

@abretaud
Copy link

Hi!
I've seen the latest 1.3.5 release, but I can't find it on https://www.npmjs.com/package/@jbrowse/cli, maybe there was a problem with 1.3.4? (Or maybe I'm just too impatient :D )

To Reproduce

Go to https://www.npmjs.com/package/@jbrowse/cli and see that there's no 1.3.5
Or get this error when installing:

No matching version found for @jbrowse/cli@1.3.5.
In most cases you or one of your dependencies are requesting
notarget a package version that doesn't exist.

(By the way, FYI I'm working on updating the Galaxy JBrowse tool to JBrowse2:
image
)

Expected behavior

Screenshots

Version:

Additional context

@abretaud abretaud added the bug Something isn't working label Aug 24, 2021
@cmdcolin
Copy link
Collaborator

I think I realized this as well. you should be fine with 1.3.4 and you will get the latest stuff with it.

The reason you see this is that our github is a "monorepo" with multiple packages that are published each time we run a release e.g. "@jbrowse/react-linear-genome-view" "@jbrowse/cli" etc, but it tries to be smart and detects if nothing has changed for a particular package between versions, and in this case will not add a new update to npm (this also implies that versions in our monorepo can go from 1.3.3->1.3.5 for example)

In this case, we made released 1.3.4 and almost everything was detected as changed so everything got version bumped, but there was a small issue with 1.3.4 so 1.3.5 was also released, so some packages that didn't have the small issue and thus didn't have any changes after the 1.3.4 release didn't get updated to 1.3.5.

anyways, hope that helps.

excellent work on the galaxy integration too

@abretaud
Copy link
Author

Humpff, I see this problem while trying to update the bioconda package (bioconda/bioconda-recipes#30221) which uses the github version... There's no way to force a 1.3.5 deposit on npm?

@cmdcolin
Copy link
Collaborator

cmdcolin commented Aug 24, 2021

your best bet would maybe be to distinguish between the cli version and the web version, there will definitely be cases where cli may not publish a new version and web does. there is not a requirement for the cli to be in lockstep with the web

@cmdcolin
Copy link
Collaborator

random other note: it's not necessarily required to bump the version of @jbrowse/cli to get the latest version of jbrowse-web. it is probably a good idea to get the latest cli just because of the general bug fixes and improvements but the cli may get updated separately.

it could possibly even be a separate formula in bioconda maybe?

@abretaud
Copy link
Author

Ok, thanks for the details :) I've pinned the cli to 1.3.4 in the recipe, we'll just have to remember to update for later releases (added a comment in the recipe for that). We'll see later if it's worth splitting it in a separate package

@cmdcolin
Copy link
Collaborator

Future versions should always publish everything on release due to #2263 so hopefully this problem wont occur in the future...:)

@abretaud
Copy link
Author

Ah ok, good to know :) I'll change back the bioconda recipe next time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants