Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force publish all packages on release #2263

Merged
merged 1 commit into from
Aug 30, 2021
Merged

Force publish all packages on release #2263

merged 1 commit into from
Aug 30, 2021

Conversation

cmdcolin
Copy link
Collaborator

This attempts to force publish all packages on each release, despite if they have not changed

This could be considered overkill and a reaction to the v1.3.4 to v1.3.5 release thing but it seemed to have resulted in a fair bit of confusion. It may be best to publish all every time. The only downside may be taking up a bit more npmjs.com server space

https://lerna.js.org/#command-publish

@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Aug 27, 2021
@cmdcolin
Copy link
Collaborator Author

This isn't tested but I believe this uses the documented lerna publish option in the right way

@codecov
Copy link

codecov bot commented Aug 27, 2021

Codecov Report

Merging #2263 (ca34908) into main (dca2afa) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2263   +/-   ##
=======================================
  Coverage   62.81%   62.81%           
=======================================
  Files         495      495           
  Lines       22946    22946           
  Branches     5193     5193           
=======================================
  Hits        14414    14414           
  Misses       8265     8265           
  Partials      267      267           
Impacted Files Coverage Δ
packages/core/util/index.ts 79.84% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dca2afa...ca34908. Read the comment docs.

@cmdcolin cmdcolin added internal and removed needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) labels Aug 27, 2021
@cmdcolin
Copy link
Collaborator Author

@garrettjstevens this is random but the jbrowse-web for example isn't published, this will still work for it though?

@garrettjstevens
Copy link
Collaborator

I think so, since that flag gets passed to the "version" command, which should update the version whether or not it's published.

@cmdcolin
Copy link
Collaborator Author

super...I figured somehow lerna was bumping jbrowse-web:)

@cmdcolin cmdcolin marked this pull request as ready for review August 30, 2021 19:56
@cmdcolin cmdcolin merged commit 24fe4ca into main Aug 30, 2021
@cmdcolin cmdcolin deleted the force_publish_all branch August 30, 2021 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants