Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot change display type on lgv #3121

Closed
carolinebridge opened this issue Aug 2, 2022 · 1 comment · Fixed by #3120
Closed

Cannot change display type on lgv #3121

carolinebridge opened this issue Aug 2, 2022 · 1 comment · Fixed by #3120
Labels
bug Something isn't working

Comments

@carolinebridge
Copy link
Contributor

Cannot change the display type on a linear genome view.

v2.1.0, noticed on web.

Haven't extensively tested, but based on where it's happening in the code I assume this is all displays.

Noticed when trying to change the display type on an alignments track:

react-dom.production.min.js:101 Uncaught TypeError: Cannot read properties of undefined (reading 'displayId')
    at BaseTrackModel.ts:128:57
    at observablearray.ts:558:29
    at Array.findIndex (<anonymous>)
    at Proxy.<anonymous> (observablearray.ts:557:31)
    at Object.replaceDisplay (BaseTrackModel.ts:128:35)
    at Le (action.ts:68:19)
    at bound replaceDisplay (action.ts:49:16)
    at mobx-state-tree.module.js:3254:35
    at Te (mobx-state-tree.module.js:3097:16)
    at Proxy.n (mobx-state-tree.module.js:3124:16)

function replaceDisplay line 128 const idx = self.displays.findIndex(d => d.conf.displayId === oldId) in BaseTrackModel.ts

@carolinebridge carolinebridge added the bug Something isn't working label Aug 2, 2022
@garrettjstevens
Copy link
Collaborator

I think this will be fixed with #3120

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants