Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix menu items for changing display type from track menu #3120

Merged
merged 1 commit into from
Aug 17, 2022

Conversation

cmdcolin
Copy link
Collaborator

@cmdcolin cmdcolin commented Aug 2, 2022

Fixes issue noted here https://sourceforge.net/p/gmod/mailman/message/37688532/

There were cosmetic refactorings that broke the code in this case in v2.0.0

@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Aug 2, 2022
@cmdcolin cmdcolin added bug Something isn't working and removed needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) labels Aug 2, 2022
@codecov
Copy link

codecov bot commented Aug 2, 2022

Codecov Report

Merging #3120 (ad9bf14) into main (ad9bf14) will not change coverage.
The diff coverage is n/a.

❗ Current head ad9bf14 differs from pull request most recent head ba68634. Consider uploading reports for the commit ba68634 to get more accurate results

@@           Coverage Diff           @@
##             main    #3120   +/-   ##
=======================================
  Coverage   58.81%   58.81%           
=======================================
  Files         648      648           
  Lines       29042    29042           
  Branches     7067     7067           
=======================================
  Hits        17082    17082           
  Misses      11581    11581           
  Partials      379      379           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@garrettjstevens garrettjstevens linked an issue Aug 2, 2022 that may be closed by this pull request
@garrettjstevens garrettjstevens merged commit fd576f6 into main Aug 17, 2022
@garrettjstevens garrettjstevens deleted the fix_displaytype_change branch August 17, 2022 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot change display type on lgv
2 participants