Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Desktop snap package for electron-builder fails #4260

Closed
cmdcolin opened this issue Mar 6, 2024 · 2 comments · Fixed by #4353
Closed

Desktop snap package for electron-builder fails #4260

cmdcolin opened this issue Mar 6, 2024 · 2 comments · Fixed by #4353
Labels
bug Something isn't working

Comments

@cmdcolin
Copy link
Collaborator

cmdcolin commented Mar 6, 2024

see failed release of linux snap build here https://github.com/GMOD/jbrowse-components/actions/runs/8164836622/job/22320895938

something in electron-builder changed the config to publish to the snap store by default. snap store is interesting and could be tried but we do not do this now

related to a change in electron-builder dentified by @garrettjstevens and myself here electron-userland/electron-builder#7908

would require deep dive to try to fix

since the appimage is successfully uploaded to the release page of github, we can just cut a release...

@cmdcolin cmdcolin added the bug Something isn't working label Mar 6, 2024
@cmdcolin
Copy link
Collaborator Author

cmdcolin commented Mar 6, 2024

since the release logs are purged after a couple weeks here is a copy

2024-03-06T00:18:09.4219806Z   • electron-builder  version=24.13.3 os=6.5.0-1015-azure
2024-03-06T00:18:09.4273029Z   • loaded configuration  file=package.json ("build" field)
2024-03-06T00:18:09.6102692Z   • packaging       platform=linux arch=x64 electron=29.1.0 appOutDir=dist/linux-unpacked
2024-03-06T00:18:09.7907451Z   • downloading     url=https://github.com/electron/electron/releases/download/v29.1.0/electron-v29.1.0-linux-x64.zip size=103 MB parts=8
2024-03-06T00:18:10.1508811Z   • downloaded      url=https://github.com/electron/electron/releases/download/v29.1.0/electron-v29.1.0-linux-x64.zip duration=534ms
2024-03-06T00:18:24.3601969Z   • skipping "afterSign" hook as no signing occurred, perhaps you intended "afterPack"?
2024-03-06T00:18:24.3607236Z   • building        target=snap arch=x64 file=dist/jbrowse-desktop-v2.10.3-linux.snap
2024-03-06T00:18:24.3609855Z   • building        target=AppImage arch=x64 file=dist/jbrowse-desktop-v2.10.3-linux.AppImage
2024-03-06T00:18:24.6210341Z   • downloading     url=https://github.com/electron-userland/electron-builder-binaries/releases/download/appimage-12.0.1/appimage-12.0.1.7z size=1.6 MB parts=1
2024-03-06T00:18:24.7360622Z   • downloaded      url=https://github.com/electron-userland/electron-builder-binaries/releases/download/appimage-12.0.1/appimage-12.0.1.7z duration=364ms
2024-03-06T00:18:25.1396644Z   • downloading     url=https://github.com/electron-userland/electron-builder-binaries/releases/download/snap-template-4.0-2/snap-template-electron-4.0-2-amd64.tar.7z size=1.5 MB parts=1
2024-03-06T00:18:25.2494060Z   • downloaded      url=https://github.com/electron-userland/electron-builder-binaries/releases/download/snap-template-4.0-2/snap-template-electron-4.0-2-amd64.tar.7z duration=324ms
2024-03-06T00:18:45.6500142Z   • publishing      publisher=Github (owner: GMOD, project: jbrowse-components, version: 2.10.3)
2024-03-06T00:18:45.6519156Z   • uploading       file=jbrowse-desktop-v2.10.3-linux.AppImage provider=github
2024-03-06T00:19:06.0738775Z   • publishing      publisher=Snap Store
2024-03-06T00:19:06.0740178Z   • uploading       file=jbrowse-desktop-v2.10.3-linux.snap provider=snapStore
2024-03-06T00:19:06.0828879Z   ⨯ snapcraft is not installed, please: sudo snap install snapcraft --classic  
2024-03-06T00:19:06.0966400Z   ⨯ /home/runner/work/jbrowse-components/jbrowse-components/node_modules/app-builder-bin/linux/x64/app-builder process failed ERR_ELECTRON_BUILDER_CANNOT_EXECUTE
2024-03-06T00:19:06.0969784Z Exit code:
2024-03-06T00:19:06.1031630Z 1  failedTask=build stackTrace=Error: /home/runner/work/jbrowse-components/jbrowse-components/node_modules/app-builder-bin/linux/x64/app-builder process failed ERR_ELECTRON_BUILDER_CANNOT_EXECUTE
2024-03-06T00:19:06.1033738Z Exit code:
2024-03-06T00:19:06.1034257Z 1
2024-03-06T00:19:06.1035956Z     at ChildProcess.<anonymous> (/home/runner/work/jbrowse-components/jbrowse-components/node_modules/builder-util/src/util.ts:252:14)
2024-03-06T00:19:06.1037560Z     at Object.onceWrapper (node:events:633:26)
2024-03-06T00:19:06.1038575Z     at ChildProcess.emit (node:events:518:28)
2024-03-06T00:19:06.1039579Z     at maybeClose (node:internal/child_process:1105:16)
2024-03-06T00:19:06.1040726Z     at Process.ChildProcess._handle.onexit (node:internal/child_process:305:5)
2024-03-06T00:19:06.1260795Z error Command failed with exit code 1.
2024-03-06T00:19:06.1262339Z info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
2024-03-06T00:19:06.1374586Z ##[error]Process completed with exit code 1.
2024-03-06T00:19:06.1466482Z Post job cleanup.
2024-03-06T00:19:06.2192181Z [command]/usr/bin/git version

@cmdcolin
Copy link
Collaborator Author

still fails

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant