Bold insertion indicator for large insertions on pileup track #1688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
needs label triage
Codecov Report
@@ Coverage Diff @@
## master #1688 +/- ##
=======================================
Coverage 58.96% 58.96%
=======================================
Files 446 446
Lines 20434 20441 +7
Branches 4813 4816 +3
=======================================
+ Hits 12048 12053 +5
- Misses 8088 8090 +2
Partials 298 298
Continue to review full report at Codecov.
|
cmdcolin
added
enhancement
cmdcolin
force-pushed
the
insertion_bold_indicator
branch
from
d3cde9c
to
0026f11
Compare
|
Better example screenshot, using HG002 CRAM and dbVar VCF for HG002 (added to test data here) |
|
Note that there is a thing where snps can get drawn on top of the insertion indicator so we could consider making something to fix this, or accept it as is... |
cmdcolin
force-pushed
the
insertion_bold_indicator
branch
from
1dc3a11
to
ac9dd05
Compare
|
renders them as a second pass now, so snp rendering doesn't overlap the bold markers
|
cmdcolin
force-pushed
the
insertion_bold_indicator
branch
from
ac9dd05
to
4f48c5c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sort of tangential but related goals to elucidating insertions as #1687
Adds similar insertion indicator seen in igv
Ref fig S2 https://static-content.springer.com/esm/art%3A10.1186%2Fs13059-020-02107-y/MediaObjects/13059_2020_2107_MOESM1_ESM.docx from https://genomebiology.biomedcentral.com/articles/10.1186/s13059-020-02107-y#Sec22
The insertion signal for the 6000bp insertion is dispersed by complicated mapping, but can be pieced together from the large numbers
I arbitrarily thresholded it so that len<10 it draws line indicator, and larger than than it makes the bold indicator which draws it as wide as needed to accommodate the number