External plugins load after confirming config warning #1748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…set config to default config.json if they decline loading the cross origin config
github-actions
bot
added
the
needs label triage
Codecov Report
@@ Coverage Diff @@
## master #1748 +/- ##
==========================================
- Coverage 58.80% 58.75% -0.06%
==========================================
Files 454 455 +1
Lines 21007 21027 +20
Branches 4975 4975
==========================================
+ Hits 12354 12355 +1
- Misses 8343 8362 +19
Partials 310 310
Continue to review full report at Codecov.
|
|
Visiting http://localhost:3000/?config=test_data/config_demo.json has an error currently about GDCTrack not being found on this branch |
peterkxie
added
bug
rbuels
reviewed
Mar 1, 2021
rbuels
reviewed
Mar 1, 2021
|
Is this one ready now? |
|
Looks good to me :) |
|
merge'd |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #1692, now the config warning modal holds off fetchPlugins until after the user confirms that they trust the source, so external plugins get loaded after. Cancel resets to default configuration (same logic as onFactoryReset)
Making as draft for now because not too sure how to handle the cancel case. Assuming they do not want to load the cross origin config, will have to atleast clear the config in the URL and in the configPath and set it to the default config (config.json). If clearing the config, may have to clear the session since that session may have info recorded using the previous config (such as confirming, loading a view, and then refresh and not confirming/cancel the second time).