Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dialog for launching breakpoint split view from variant feature details #1831

Merged
merged 1 commit into from Mar 23, 2021

Conversation

cmdcolin
Copy link
Collaborator

This is a demo for launching a breakpoint split view from a variant feature details panel

Note that there could be a similar thing dialog needed for alignments

An add on to this exists for side-by-side breakpoint split view but that may need more work (see branch side_by_side_dialog)

@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Mar 19, 2021
@cmdcolin cmdcolin force-pushed the dialog_for_breakpoint_split_view branch from 9cd6e5d to 7ae6c08 Compare March 19, 2021 22:39
@cmdcolin cmdcolin added enhancement New feature or request and removed needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) labels Mar 19, 2021
Add dep
@cmdcolin cmdcolin force-pushed the dialog_for_breakpoint_split_view branch from 7ae6c08 to b67c884 Compare March 20, 2021 15:47
@codecov
Copy link

codecov bot commented Mar 20, 2021

Codecov Report

Merging #1831 (b67c884) into master (e2594e3) will decrease coverage by 0.07%.
The diff coverage is 14.28%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1831      +/-   ##
==========================================
- Coverage   58.85%   58.77%   -0.08%     
==========================================
  Files         459      460       +1     
  Lines       21389    21421      +32     
  Branches     5051     5060       +9     
==========================================
+ Hits        12589    12591       +2     
- Misses       8489     8519      +30     
  Partials      311      311              
Impacted Files Coverage Δ
.../src/VariantFeatureWidget/VariantFeatureWidget.tsx 44.00% <0.00%> (-1.21%) ⬇️
.../src/VariantFeatureWidget/BreakendOptionDialog.tsx 3.44% <3.44%> (ø)
plugins/breakpoint-split-view/src/model.ts 43.93% <100.00%> (+0.42%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b3cb73a...b67c884. Read the comment docs.

@rbuels rbuels merged commit 5c8cb40 into master Mar 23, 2021
@rbuels rbuels deleted the dialog_for_breakpoint_split_view branch March 23, 2021 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants