Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 3'UTR in sequence detail panels when no UTRs are in gff #2018

Merged
merged 3 commits into from May 28, 2021

Conversation

cmdcolin
Copy link
Collaborator

This fixes an off-by-one bug in the display of "cDNA" sequences in the feature panel. Might need to follow up with some confirmation

@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label May 27, 2021
@codecov
Copy link

codecov bot commented May 27, 2021

Codecov Report

Merging #2018 (90b10bb) into main (d690c35) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2018      +/-   ##
==========================================
- Coverage   60.87%   60.84%   -0.03%     
==========================================
  Files         473      473              
  Lines       22549    22549              
  Branches     5244     5244              
==========================================
- Hits        13727    13721       -6     
- Misses       8539     8546       +7     
+ Partials      283      282       -1     
Impacted Files Coverage Δ
.../core/BaseFeatureWidget/SequenceFeatureDetails.tsx 56.05% <ø> (+1.91%) ⬆️
...nts/src/SNPCoverageRenderer/SNPCoverageRenderer.ts 80.24% <0.00%> (-7.41%) ⬇️
...inearGenomeView/components/RefNameAutocomplete.tsx 88.88% <0.00%> (-4.45%) ⬇️
packages/core/util/analytics.ts 83.72% <0.00%> (-2.33%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d690c35...90b10bb. Read the comment docs.

@rbuels rbuels added bug Something isn't working and removed needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) labels May 27, 2021
@cmdcolin cmdcolin marked this pull request as ready for review May 27, 2021 20:09
@cmdcolin cmdcolin merged commit 76a3b0d into main May 28, 2021
@cmdcolin cmdcolin changed the title Fix off-by-one bug in displaying cDNA sequences Fix 3'UTR in sequence detail panels when no UTRs are in gff May 28, 2021
@cmdcolin cmdcolin deleted the sequence_details branch May 28, 2021 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants