Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a helpful message if there is a 404 on config.json error #2203

Merged
merged 2 commits into from Aug 13, 2021

Conversation

cmdcolin
Copy link
Collaborator

Tries to help with #2171

Based on the idea that a red error box for a 404 not found error might be overly scary, so it specifically detects this case and displays a green message instead of a red one

localhost_3000_

@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Aug 10, 2021
@codecov
Copy link

codecov bot commented Aug 10, 2021

Codecov Report

Merging #2203 (4e9fced) into main (b5cb5ab) will decrease coverage by 0.01%.
The diff coverage is 86.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2203      +/-   ##
==========================================
- Coverage   62.56%   62.54%   -0.02%     
==========================================
  Files         484      484              
  Lines       22707    22712       +5     
  Branches     5152     5152              
==========================================
  Hits        14206    14206              
- Misses       8231     8237       +6     
+ Partials      270      269       -1     
Impacted Files Coverage Δ
products/jbrowse-web/src/Loader.tsx 62.54% <86.66%> (+0.97%) ⬆️
...nts/src/SNPCoverageRenderer/SNPCoverageRenderer.ts 80.24% <0.00%> (-7.41%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5cb5ab...4e9fced. Read the comment docs.

@cmdcolin cmdcolin added enhancement New feature or request and removed needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) labels Aug 10, 2021
@cmdcolin cmdcolin force-pushed the loader_config_loading_helpful_message branch from f99befe to f3da256 Compare August 10, 2021 18:25
@elliothershberg
Copy link
Member

From discussion of this PR in grooming, we opted to link people to our web quickstart guide if no config is found.

@cmdcolin
Copy link
Collaborator Author

looks good

has big "error: operation completed successfully" vibes :)

image

image

@cmdcolin cmdcolin merged commit 4ea2778 into main Aug 13, 2021
@cmdcolin cmdcolin deleted the loader_config_loading_helpful_message branch August 13, 2021 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants