Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add example of defining and using a plugin with the embedded component #2437

Merged
merged 1 commit into from
Oct 21, 2021

Conversation

cmdcolin
Copy link
Collaborator

The current example in storybook fetches the plugin from an external URL

It was difficult to e.g. npm require the plugin, but we can actually define one inline (and this is actually useful for users too, see #2261

This adds an example similar to #2261 for reference

@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Oct 21, 2021
@codecov
Copy link

codecov bot commented Oct 21, 2021

Codecov Report

Merging #2437 (9aff224) into main (6d9b1c2) will increase coverage by 0.00%.
The diff coverage is n/a.

❗ Current head 9aff224 differs from pull request most recent head 8c88ecb. Consider uploading reports for the commit 8c88ecb to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2437   +/-   ##
=======================================
  Coverage   60.83%   60.84%           
=======================================
  Files         538      538           
  Lines       24870    24870           
  Branches     5838     5838           
=======================================
+ Hits        15130    15131    +1     
+ Misses       9424     9423    -1     
  Partials      316      316           
Impacted Files Coverage Δ
products/jbrowse-web/src/util.ts 27.27% <0.00%> (ø)
packages/core/util/analytics.ts 90.69% <0.00%> (+2.32%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d9b1c2...8c88ecb. Read the comment docs.

@cmdcolin cmdcolin added documentation and removed needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) labels Oct 21, 2021
@cmdcolin cmdcolin force-pushed the add_inline_plugin_example_storybook branch from 9aff224 to 8c88ecb Compare October 21, 2021 17:11
@cmdcolin cmdcolin merged commit a47c5fd into main Oct 21, 2021
@carolinebridge carolinebridge deleted the add_inline_plugin_example_storybook branch October 22, 2021 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant