Fix crash when chromSizesLocation not specified when loading TwoBitAdapter in GUI #2444
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently loading a twobit file from the desktop start screen fails, and fails with a big snapshot failure that crashes the app
There is a assumption in some usages of FileSelector where a "blank location object" is {uri:''}
Then, with TwoBitAdapter in particular, the "chromSizesLocation" is an optional entry that speeds up loading the twoBit, but if chromSizesLocation is not specified, then loading fails.
Specifically, it fails to go through the FileLocation preprocessor however because empty string doesn't pass the check
This PR explicitly checks for
this helps the locationType get added, and therefore not have an big app crashing error