Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add assembly manager back into tools menu on jbrowse-desktop #2461

Merged
merged 2 commits into from
Oct 27, 2021

Conversation

cmdcolin
Copy link
Collaborator

Was missing. still available in admin-server on web

@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Oct 27, 2021
@cmdcolin cmdcolin added enhancement New feature or request and removed needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) labels Oct 27, 2021
@codecov
Copy link

codecov bot commented Oct 27, 2021

Codecov Report

Merging #2461 (a6b45ef) into main (6af6da5) will increase coverage by 0.02%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2461      +/-   ##
==========================================
+ Coverage   61.18%   61.20%   +0.02%     
==========================================
  Files         539      539              
  Lines       25057    25059       +2     
  Branches     5849     5849              
==========================================
+ Hits        15330    15337       +7     
+ Misses       9409     9404       -5     
  Partials      318      318              
Impacted Files Coverage Δ
products/jbrowse-desktop/src/rootModel.ts 0.00% <0.00%> (ø)
...nts/src/SNPCoverageRenderer/SNPCoverageRenderer.ts 80.24% <0.00%> (-7.41%) ⬇️
...gFeatureRenderer/components/ProcessedTranscript.js 86.48% <0.00%> (+1.35%) ⬆️
...gins/svg/src/SvgFeatureRenderer/components/util.ts 98.03% <0.00%> (+1.96%) ⬆️
packages/core/TextSearch/TextSearchManager.ts 100.00% <0.00%> (+3.44%) ⬆️
...inearGenomeView/components/RefNameAutocomplete.tsx 86.02% <0.00%> (+10.75%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6af6da5...a6b45ef. Read the comment docs.

@cmdcolin
Copy link
Collaborator Author

Note that if you add an assembly, and want to edit refNameAliases later, it will not be possible with this PR/on main

It is actually fixed by assembly config schema changes in #2267

@cmdcolin
Copy link
Collaborator Author

we could also consider adding a refnamealiases slot for when the user is initially adding the assembly perhaps also

@cmdcolin cmdcolin merged commit 47adacd into main Oct 27, 2021
@cmdcolin cmdcolin deleted the assembly_manager_desktop branch October 27, 2021 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant