Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add polyfill for text-index compatibility with node 10 #2494

Merged
merged 1 commit into from
Nov 4, 2021

Conversation

cmdcolin
Copy link
Collaborator

@cmdcolin cmdcolin commented Nov 4, 2021

This adds a Object.fromEntries polyfill for use in text-index for the CLI

Our CLI currently says it is compatible with node 10.4+ which needs a Object.fromEntries polyfill

xref #2359

We could also bump min to node 12 but this isn't too bad for now

@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Nov 4, 2021
@codecov
Copy link

codecov bot commented Nov 4, 2021

Codecov Report

Merging #2494 (31204eb) into main (78b2adc) will decrease coverage by 0.00%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2494      +/-   ##
==========================================
- Coverage   61.18%   61.18%   -0.01%     
==========================================
  Files         543      543              
  Lines       25250    25252       +2     
  Branches     5902     5903       +1     
==========================================
+ Hits        15450    15451       +1     
- Misses       9479     9480       +1     
  Partials      321      321              
Impacted Files Coverage Δ
products/jbrowse-cli/src/commands/text-index.ts 69.76% <50.00%> (-0.32%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 78b2adc...31204eb. Read the comment docs.

@cmdcolin cmdcolin changed the title Add Object.fromEntries polyfill for use in text-index CLI Add Object.fromEntries polyfill for @jbrowse/cli text-index compatibility with node 10 Nov 4, 2021
@cmdcolin cmdcolin added bug Something isn't working and removed needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) labels Nov 4, 2021
@cmdcolin cmdcolin changed the title Add Object.fromEntries polyfill for @jbrowse/cli text-index compatibility with node 10 Add polyfill for text-index compatibility with node 10 Nov 4, 2021
@cmdcolin cmdcolin merged commit ff4eecc into main Nov 4, 2021
@cmdcolin cmdcolin deleted the fix_text_index_node10 branch November 4, 2021 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant