-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add stats estimation to JB2 #2497
Conversation
…e rendering wait for statsready, add estimateglobalstats to bam
want to discuss timing issues in meeting, stats estimation makes a lot of tests flaky since it takes extra time, solution seems to be increasing timeout but i'd be increasing a lot of test timeouts |
…es for test issue
…oad button and the regular block error reload button, still need to tune down the timeouts
can you link the demos showing how this works and provide some analysis of it's behavior on various files? |
plugins/linear-genome-view/src/BaseLinearDisplay/models/BaseLinearDisplayModel.tsx
Show resolved
Hide resolved
plugins/linear-genome-view/src/BaseLinearDisplay/models/BaseLinearDisplayModel.tsx
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## main #2497 +/- ##
==========================================
+ Coverage 60.70% 60.86% +0.16%
==========================================
Files 547 547
Lines 25579 25732 +153
Branches 6042 6080 +38
==========================================
+ Hits 15528 15663 +135
- Misses 9725 9743 +18
Partials 326 326
Continue to review full report at Codecov.
|
the volvox filtered vcf track doesn't have very many features...i think ideally, it would not hit any feature density limit? |
here is the link to make the feature density calculation proportional to current zoom level https://github.com/GMOD/jbrowse/blob/dev/src/JBrowse/View/Track/CanvasFeatures.js#L260-L261 the "scale" is equal to 1/bpPerPx |
I'm betting the tests won't have to do as many clicks of "Force" now that it's accounting for scale |
…ar notReady from baselineardisplaymodel, remove super.notReady calls, increase a few flaky test timeouts by a little bit
if I turn on a bam or cram track e.g. viewing the entirety of chr1 it tries to download the entirety of chr1 and crashes here it is for bam. the pileup subtrack appears to succeed but the snpcoverage track tries to end up downloading stuff anyways. i think for cram, it does not have e.g. the linecount heuristic and tries to download the entirety of chr1 for both snpcov and pileup |
might suggest putting in draft a bit more, just for more testing and such |
ill look into this more, thanks for the details + screenshot |
…s region cannot be rendered
with confirmation from @peterkxie This reverts commit cbfcd97, reversing changes made to 9ba6b7b.
…on_v2"," This reverts commit e365b6f.
* add estimateStatsCache logic to other adapters to prevent extra stats calculations * prevent rpc call if stats already been calculated to stop additional reload * Remove statsStatus * Add currentFeatureScreenDensity getter * fix test and snapshot issues for statsStatus removal change * Revert "Revert "Merge pull request #2497 from GMOD/607_stats_estimation_v2"," This reverts commit e365b6f. * Encode the concept of notReady more generically instead of separate check for statsNotReady * Central bytesForRegions function * Rename method estimateGlobalStats->estimateRegionStats * Don't show limit if below 20kb viewing region size * Disable stats estimation on sequence and bigwig adapters * Rename to fetchSizeLimit and only store current bpPerPx * Use simple variables instead of nested model for statsLimit, restores the userBpPerPx field on main * Remove the byte-size estimation from bed/gff/vcf tabix adapters * Add zoom in and force load tests Co-authored-by: peterkxie <peterkxie@yahoo.com>
Add general and specific stats estimation to JBrowse 2, calculates the feature density to potentially limit the loading of tracks. BAM and Tabix files use the index to calculate their feature density