Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix drawer widget minimized button being unclickable when overlapping with a view #2533

Merged
merged 1 commit into from
Nov 17, 2021

Conversation

cmdcolin
Copy link
Collaborator

Basically appears to be overridden by the zIndex. Adds an arbitrarily higher number for zIndex. Fixes #2532

@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Nov 17, 2021
@cmdcolin cmdcolin changed the title Fix fab click with high zIndex Fix drawer widget minimized button when overlapping with a view Nov 17, 2021
@codecov
Copy link

codecov bot commented Nov 17, 2021

Codecov Report

Merging #2533 (7880502) into main (0ad2a3d) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2533      +/-   ##
==========================================
- Coverage   61.10%   61.09%   -0.01%     
==========================================
  Files         543      543              
  Lines       25141    25141              
  Branches     5901     5901              
==========================================
- Hits        15362    15360       -2     
- Misses       9456     9458       +2     
  Partials      323      323              
Impacted Files Coverage Δ
packages/core/ui/App.tsx 73.68% <ø> (ø)
...inearGenomeView/components/RefNameAutocomplete.tsx 81.39% <0.00%> (-3.49%) ⬇️
packages/core/TextSearch/TextSearchManager.ts 96.55% <0.00%> (-3.45%) ⬇️
...lignments/src/BamAdapter/BamSlightlyLazyFeature.ts 79.24% <0.00%> (+1.88%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ad2a3d...7880502. Read the comment docs.

@cmdcolin cmdcolin added bug Something isn't working and removed needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) labels Nov 17, 2021
@cmdcolin cmdcolin merged commit 41d991a into main Nov 17, 2021
@cmdcolin cmdcolin changed the title Fix drawer widget minimized button when overlapping with a view Fix drawer widget minimized button being unclickable when overlapping with a view Nov 17, 2021
@cmdcolin cmdcolin deleted the fix_fab_click branch November 17, 2021 21:22
@cmdcolin cmdcolin changed the title Fix drawer widget minimized button being unclickable when overlapping with a view Fix drawer widget minimized button being unclickable when overlapping with a view Dec 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Button for minimized widget drawer does not respond to mouse click when it overlaps with a view window
1 participant