Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hot reload using yarn resolution on react-error-overlay #2657

Merged
merged 1 commit into from
Jan 19, 2022

Conversation

cmdcolin
Copy link
Collaborator

after observing that hot reload wasn't working, I also noticed that it correlated with this error in the dev console for "process is not defined"

googling stackoverflow for this turned up
https://stackoverflow.com/questions/70357360/process-is-not-defined-on-hot-reload/70402397

adding this resoluton to the root package.json for react-error-overlay fixed it for me

fixes #2656

@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Jan 19, 2022
@cmdcolin cmdcolin added internal and removed needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) labels Jan 19, 2022
@codecov
Copy link

codecov bot commented Jan 19, 2022

Codecov Report

Merging #2657 (6b365d2) into main (616156c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2657   +/-   ##
=======================================
  Coverage   60.58%   60.58%           
=======================================
  Files         557      557           
  Lines       26001    26001           
  Branches     6343     6343           
=======================================
  Hits        15753    15753           
  Misses       9921     9921           
  Partials      327      327           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 616156c...6b365d2. Read the comment docs.

@cmdcolin cmdcolin merged commit 53deb38 into main Jan 19, 2022
@cmdcolin cmdcolin deleted the fix_hot_reload branch January 19, 2022 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hot reload not working on jbrowse-web in dev mode
1 participant