Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimizations and usability improvements to synteny view #2679

Merged
merged 8 commits into from
Jan 27, 2022
Merged

Conversation

cmdcolin
Copy link
Collaborator

@cmdcolin cmdcolin commented Jan 27, 2022

  • Adds resize handle to the linear synteny view
  • Adds optimization to the linear synteny view similar to what was done for dotplot: bypass using the observables and operate on snapshot
  • Avoid creating a syntenytrack from import form on dotplot/synteny view if none was specified

@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Jan 27, 2022
@cmdcolin
Copy link
Collaborator Author

example screenshot

Screenshot from 2022-01-27 10-11-17

@codecov
Copy link

codecov bot commented Jan 27, 2022

Codecov Report

Merging #2679 (4d09f51) into main (7a24a88) will decrease coverage by 0.01%.
The diff coverage is 23.52%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2679      +/-   ##
==========================================
- Coverage   60.73%   60.72%   -0.02%     
==========================================
  Files         561      561              
  Lines       26270    26279       +9     
  Branches     6394     6397       +3     
==========================================
+ Hits        15955    15957       +2     
- Misses       9988     9995       +7     
  Partials      327      327              
Impacted Files Coverage Δ
packages/core/util/index.ts 85.38% <ø> (ø)
...arative-view/src/LinearComparativeDisplay/index.ts 5.88% <ø> (ø)
...ew/src/LinearComparativeView/components/Header.tsx 0.00% <0.00%> (ø)
...mparativeView/components/LinearComparativeView.tsx 0.00% <0.00%> (ø)
...omparative-view/src/LinearComparativeView/model.ts 7.14% <0.00%> (-0.39%) ⬇️
...comparative-view/src/LinearSyntenyDisplay/index.ts 28.57% <ø> (+3.57%) ⬆️
...tenyRenderer/components/LinearSyntenyRendering.tsx 1.35% <0.00%> (-0.02%) ⬇️
...ew/src/LinearSyntenyView/components/ImportForm.tsx 0.00% <0.00%> (ø)
plugins/linear-comparative-view/src/util.ts 1.88% <0.00%> (ø)
...lot-view/src/DotplotView/components/ImportForm.tsx 83.33% <85.71%> (+0.47%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a24a88...4d09f51. Read the comment docs.

@cmdcolin cmdcolin added enhancement New feature or request and removed needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) labels Jan 27, 2022
@cmdcolin cmdcolin merged commit c9b7519 into main Jan 27, 2022
@cmdcolin cmdcolin deleted the misc_updates branch January 27, 2022 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant