Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix disabled state on the linear genome view track labels dropdown menu #2695

Merged
merged 3 commits into from
Feb 1, 2022

Conversation

cmdcolin
Copy link
Collaborator

Currently the track menu can be disabled in embedded mode if there are no "items" but there should always be at least an "About track" dialog

@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Jan 31, 2022
@cmdcolin cmdcolin removed the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Jan 31, 2022
@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Jan 31, 2022
@cmdcolin cmdcolin changed the title Don't have a disabled state for the track menu Fix disabled state on the linear genome view track labels dropdown menu Jan 31, 2022
@cmdcolin cmdcolin added enhancement New feature or request bug Something isn't working and removed needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) enhancement New feature or request labels Jan 31, 2022
@codecov
Copy link

codecov bot commented Jan 31, 2022

Codecov Report

Merging #2695 (e50ea88) into main (b7184e1) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2695      +/-   ##
==========================================
- Coverage   60.71%   60.71%   -0.01%     
==========================================
  Files         561      561              
  Lines       26350    26350              
  Branches     6425     6425              
==========================================
- Hits        15999    15998       -1     
- Misses      10025    10026       +1     
  Partials      326      326              
Impacted Files Coverage Δ
...iew/src/LinearGenomeView/components/TrackLabel.tsx 97.05% <100.00%> (ø)
...ckages/core/pluggableElementTypes/RpcMethodType.ts 83.33% <0.00%> (-2.09%) ⬇️
products/jbrowse-web/src/util.ts 27.27% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b7184e1...e50ea88. Read the comment docs.

@cmdcolin cmdcolin merged commit 4b0d651 into main Feb 1, 2022
@cmdcolin cmdcolin deleted the show_track_menu branch February 1, 2022 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant