Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add engines 16 to @jbrowse/img #2727

Merged
merged 1 commit into from
Feb 9, 2022
Merged

Add engines 16 to @jbrowse/img #2727

merged 1 commit into from
Feb 9, 2022

Conversation

cmdcolin
Copy link
Collaborator

@cmdcolin cmdcolin commented Feb 9, 2022

This is required, unless we want to add a AbortController poly/ponyfill

On node 12 and node 14 it produces this error

 jb2export --bigwig src/jbrowse-components/test_data/volvox/volvox-sorted.bam.coverage.bw --loc ctgA:1000-2000 --fasta src/jbrowse-components/test_data/volvox/volvox.fa
(node:1965899) UnhandledPromiseRejectionWarning: ReferenceError: AbortController is not defined
    at _callee$ (/home/cdiesh/.nvm/versions/node/v12.22.7/lib/node_modules/@jbrowse/img/node_modules/@jbrowse/core/util/index.js:881:15)
    at tryCatch (/home/cdiesh/.nvm/versions/node/v12.22.7/lib/node_modules/@jbrowse/img/node_modules/regenerator-runtime/runtime.js:63:40)
    at Generator.invoke [as _invoke] (/home/cdiesh/.nvm/versions/node/v12.22.7/lib/node_modules/@jbrowse/img/node_modules/regenerator-runtime/runtime.js:294:22)
    at Generator.next (/home/cdiesh/.nvm/versions/node/v12.22.7/lib/node_modules/@jbrowse/img/node_modules/regenerator-runtime/runtime.js:119:21)
    at asyncGeneratorStep (/home/cdiesh/.nvm/versions/node/v12.22.7/lib/node_modules/@jbrowse/img/node_modules/@babel/runtime/helpers/asyncToGenerator.js:3:24)
    at _next (/home/cdiesh/.nvm/versions/node/v12.22.7/lib/node_modules/@jbrowse/img/node_modules/@babel/runtime/helpers/asyncToGenerator.js:25:9)
    at /home/cdiesh/.nvm/versions/node/v12.22.7/lib/node_modules/@jbrowse/img/node_modules/@babel/runtime/helpers/asyncToGenerator.js:32:7
    at new Promise (<anonymous>)
    at /home/cdiesh/.nvm/versions/node/v12.22.7/lib/node_modules/@jbrowse/img/node_modules/@babel/runtime/helpers/asyncToGenerator.js:21:12
    at /home/cdiesh/.nvm/versions/node/v12.22.7/lib/node_modules/@jbrowse/img/node_modules/@jbrowse/core/util/index.js:918:19
(node:1965899) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 1)
(node:1965899) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.

@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Feb 9, 2022
@cmdcolin cmdcolin added bug Something isn't working and removed needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) labels Feb 9, 2022
@codecov
Copy link

codecov bot commented Feb 9, 2022

Codecov Report

Merging #2727 (d35c667) into main (b43ed81) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2727      +/-   ##
==========================================
- Coverage   60.75%   60.73%   -0.02%     
==========================================
  Files         561      561              
  Lines       26346    26346              
  Branches     6424     6424              
==========================================
- Hits        16007    16002       -5     
- Misses      10013    10018       +5     
  Partials      326      326              
Impacted Files Coverage Δ
...nts/src/SNPCoverageRenderer/SNPCoverageRenderer.ts 66.05% <0.00%> (-5.51%) ⬇️
...ckages/core/pluggableElementTypes/RpcMethodType.ts 85.41% <0.00%> (+2.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b43ed81...d35c667. Read the comment docs.

@rbuels rbuels merged commit ca86e63 into main Feb 9, 2022
@rbuels rbuels deleted the engines_16_jbimg branch February 9, 2022 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants