Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add better catch for XS and TS tag detection from CRAM #2738

Merged
merged 1 commit into from
Feb 11, 2022

Conversation

cmdcolin
Copy link
Collaborator

@cmdcolin cmdcolin commented Feb 11, 2022

Fixes #2737

The sashimi arc drawing was using feature.get('tags').XS as a fallback for CRAM (CRAM does not use feature.get('XS')), but it didn't take into account that this would be undefined in BAM files. The getTag helper function already helps with this

@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Feb 11, 2022
@codecov
Copy link

codecov bot commented Feb 11, 2022

Codecov Report

Merging #2738 (57bcfd6) into main (40eb4d7) will increase coverage by 0.02%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2738      +/-   ##
==========================================
+ Coverage   60.77%   60.79%   +0.02%     
==========================================
  Files         561      561              
  Lines       26333    26330       -3     
  Branches     6417     6414       -3     
==========================================
+ Hits        16004    16008       +4     
+ Misses      10003     9996       -7     
  Partials      326      326              
Impacted Files Coverage Δ
...ments/src/SNPCoverageAdapter/SNPCoverageAdapter.ts 57.22% <0.00%> (+1.01%) ⬆️
...ckages/core/pluggableElementTypes/RpcMethodType.ts 83.33% <0.00%> (-2.09%) ⬇️
.../linear-genome-view/src/LinearGenomeView/index.tsx 83.94% <0.00%> (+0.16%) ⬆️
...inearGenomeView/components/RefNameAutocomplete.tsx 80.80% <0.00%> (+3.03%) ⬆️
packages/core/TextSearch/TextSearchManager.ts 100.00% <0.00%> (+3.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 40eb4d7...57bcfd6. Read the comment docs.

@cmdcolin cmdcolin added bug Something isn't working and removed needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) labels Feb 11, 2022
@cmdcolin cmdcolin merged commit 6977311 into main Feb 11, 2022
@cmdcolin cmdcolin deleted the fix_rnaseq_noxs branch February 11, 2022 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug with LinearAlignmentsDisplay visualization
1 participant