Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix overwriting broken symlink with --force in add-track CLI #2774

Merged
merged 2 commits into from
Feb 28, 2022

Conversation

cmdcolin
Copy link
Collaborator

This unconditionally performs an fs.unlink when using force so that it doesn't run into the issue with broken symlinks, mentioned in #2768 (comment)

@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Feb 27, 2022
@cmdcolin cmdcolin added bug Something isn't working and removed needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) labels Feb 27, 2022
@cmdcolin cmdcolin changed the title Fix overwriting symlink with --force Fix overwriting broken symlink with --force in add-track CLI Feb 27, 2022
@codecov
Copy link

codecov bot commented Feb 27, 2022

Codecov Report

Merging #2774 (82d86be) into main (eb7cfb7) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2774   +/-   ##
=======================================
  Coverage   60.16%   60.16%           
=======================================
  Files         572      572           
  Lines       26615    26614    -1     
  Branches     6487     6487           
=======================================
  Hits        16012    16012           
+ Misses      10278    10277    -1     
  Partials      325      325           
Impacted Files Coverage Δ
products/jbrowse-cli/src/commands/add-track.ts 63.38% <100.00%> (-0.18%) ⬇️
products/jbrowse-web/src/util.ts 27.27% <0.00%> (ø)
packages/core/util/analytics.ts 91.83% <0.00%> (+2.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb7cfb7...82d86be. Read the comment docs.

@cmdcolin cmdcolin merged commit 211a657 into main Feb 28, 2022
@cmdcolin cmdcolin deleted the fix_symlink branch February 28, 2022 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant