Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix display of cytobands when horizontally flipped #2782

Merged
merged 2 commits into from
Mar 3, 2022

Conversation

cmdcolin
Copy link
Collaborator

@cmdcolin cmdcolin commented Mar 1, 2022

Currently the little "caps" on the ends of the cytobands are in the wrong orientation if the view is horizontally flipped

This fixes that

Note that we could also consider making a better indication of horizontally flipped status when cytobands are visible. The <<< chevrons from when the cytoband is not present are not used when the cytoband is present

@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Mar 1, 2022
@codecov
Copy link

codecov bot commented Mar 1, 2022

Codecov Report

Merging #2782 (a1fe4a4) into main (01bffe2) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2782      +/-   ##
==========================================
- Coverage   60.17%   60.16%   -0.01%     
==========================================
  Files         572      572              
  Lines       26613    26616       +3     
  Branches     6485     6488       +3     
==========================================
  Hits        16014    16014              
- Misses      10274    10277       +3     
  Partials      325      325              
Impacted Files Coverage Δ
...c/LinearGenomeView/components/OverviewScaleBar.tsx 65.04% <0.00%> (-1.63%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 01bffe2...a1fe4a4. Read the comment docs.

@cmdcolin cmdcolin added bug Something isn't working and removed needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) labels Mar 2, 2022
@cmdcolin cmdcolin merged commit 06db2c4 into main Mar 3, 2022
@cmdcolin cmdcolin deleted the fix_cytoband_flipped branch March 4, 2022 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant