Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tracklabels positioning not updating in UI after user selection #2825

Merged
merged 1 commit into from
Mar 16, 2022

Conversation

cmdcolin
Copy link
Collaborator

@cmdcolin cmdcolin commented Mar 16, 2022

There is a UI bug where selecting the tracklabels "offset" option doesn't update the UI in 1.6.7, a knock on effect of fixing a bug from 1.6.6

@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Mar 16, 2022
@cmdcolin cmdcolin added bug Something isn't working and removed needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) labels Mar 16, 2022
@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Mar 16, 2022
@codecov
Copy link

codecov bot commented Mar 16, 2022

Codecov Report

Merging #2825 (51ee3e2) into main (02012ec) will increase coverage by 0.02%.
The diff coverage is 77.77%.

@@            Coverage Diff             @@
##             main    #2825      +/-   ##
==========================================
+ Coverage   59.99%   60.01%   +0.02%     
==========================================
  Files         584      584              
  Lines       26687    26688       +1     
  Branches     6462     6462              
==========================================
+ Hits        16010    16017       +7     
+ Misses      10349    10343       -6     
  Partials      328      328              
Impacted Files Coverage Δ
...src/LinearGenomeView/components/TrackContainer.tsx 87.17% <77.77%> (+0.33%) ⬆️
...ckages/core/pluggableElementTypes/RpcMethodType.ts 83.33% <0.00%> (-2.09%) ⬇️
products/jbrowse-web/src/util.ts 27.27% <0.00%> (ø)
packages/core/util/layouts/GranularRectLayout.ts 87.17% <0.00%> (+0.42%) ⬆️
...lignments/src/BamAdapter/BamSlightlyLazyFeature.ts 78.09% <0.00%> (+1.90%) ⬆️
...s/svg/src/SvgFeatureRenderer/components/Chevron.js 97.43% <0.00%> (+10.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 02012ec...51ee3e2. Read the comment docs.

@cmdcolin cmdcolin removed the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Mar 16, 2022
@cmdcolin cmdcolin changed the title Make the LGV tracklabels function an observer Fix tracklabels positioning not updating in UI after user selection Mar 16, 2022
@cmdcolin cmdcolin merged commit 26a8881 into main Mar 16, 2022
@cmdcolin cmdcolin deleted the lgv_tracklabels_observer branch March 16, 2022 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant