Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix strand on arrows in horizontally flipped mode #2877

Merged
merged 1 commit into from
Apr 5, 2022
Merged

Conversation

cmdcolin
Copy link
Collaborator

@cmdcolin cmdcolin commented Apr 5, 2022

After the new glyph style (#2775) the arrows pointed the wrong way in horizontally flipped mode, this fixes it

@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Apr 5, 2022
@cmdcolin cmdcolin added bug Something isn't working and removed needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) labels Apr 5, 2022
@codecov
Copy link

codecov bot commented Apr 5, 2022

Codecov Report

Merging #2877 (d809617) into main (d485541) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2877      +/-   ##
==========================================
+ Coverage   59.92%   59.93%   +0.01%     
==========================================
  Files         590      590              
  Lines       26573    26578       +5     
  Branches     6450     6455       +5     
==========================================
+ Hits        15923    15929       +6     
+ Misses      10346    10345       -1     
  Partials      304      304              
Impacted Files Coverage Δ
...FeatureRenderer/components/ProcessedTranscript.tsx 87.32% <ø> (ø)
...svg/src/SvgFeatureRenderer/components/Segments.tsx 85.71% <ø> (ø)
...ns/svg/src/SvgFeatureRenderer/components/Arrow.tsx 100.00% <100.00%> (ø)
...ckages/core/pluggableElementTypes/RpcMethodType.ts 85.41% <0.00%> (+2.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d485541...d809617. Read the comment docs.

@cmdcolin cmdcolin merged commit 887a6ee into main Apr 5, 2022
@cmdcolin cmdcolin changed the title Fix strand on arrows in reverse mode Fix strand on arrows in horizontally flipped mode Apr 5, 2022
@cmdcolin cmdcolin deleted the reverse_flip_arrow branch April 5, 2022 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant