Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add simplified URL format for loading synteny views #2975

Merged
merged 5 commits into from
Jun 10, 2022
Merged

Conversation

cmdcolin
Copy link
Collaborator

Example

http://localhost:3000/?config=test_data%2Fvolvox%2Fconfig.json&session=spec-{"views":[{ "type" : "LinearSyntenyView", "tracks":["volvox_fake_synteny"],"views" :[{ "loc" : "ctgA:1-100", "assembly": "volvox" },{ "loc" : "ctgA:300-400" , "assembly" : "volvox" }]}]}

prettified json

{
  views: [
    {
      type: "LinearSyntenyView",
      tracks: ["volvox_fake_synteny"],
      views: [
        { loc: "ctgA:1-100", assembly: "volvox" },
        { loc: "ctgA:300-400", assembly: "volvox" },
      ],
    },
  ],
};

@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label May 24, 2022
@cmdcolin cmdcolin added enhancement New feature or request and removed needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) labels May 24, 2022
@codecov
Copy link

codecov bot commented May 24, 2022

Codecov Report

Merging #2975 (5f08550) into main (5f9692c) will decrease coverage by 0.07%.
The diff coverage is 51.21%.

@@            Coverage Diff             @@
##             main    #2975      +/-   ##
==========================================
- Coverage   60.80%   60.72%   -0.08%     
==========================================
  Files         584      585       +1     
  Lines       26574    26617      +43     
  Branches     6432     6449      +17     
==========================================
+ Hits        16157    16163       +6     
- Misses      10111    10145      +34     
- Partials      306      309       +3     
Impacted Files Coverage Δ
...omparative-view/src/LinearComparativeView/model.ts 21.81% <ø> (ø)
products/jbrowse-web/src/SessionLoader.ts 58.62% <0.00%> (-0.26%) ⬇️
...ar-comparative-view/src/LaunchLinearSyntenyView.ts 6.66% <6.66%> (ø)
...ew/src/JBrowseCircularGenomeView/ViewContainer.tsx 65.51% <50.00%> (+3.01%) ⬆️
...kages/core/BaseFeatureWidget/BaseFeatureDetail.tsx 73.93% <70.96%> (-2.22%) ⬇️
plugins/linear-comparative-view/src/index.tsx 93.93% <100.00%> (+0.18%) ⬆️
...quenceRenderer/components/DivSequenceRendering.tsx 92.55% <0.00%> (-2.13%) ⬇️
...ckages/core/pluggableElementTypes/RpcMethodType.ts 83.33% <0.00%> (-2.09%) ⬇️
products/jbrowse-web/src/util.ts 27.27% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6a2f84...5f08550. Read the comment docs.

@cmdcolin
Copy link
Collaborator Author

cmdcolin commented Jun 3, 2022

I think this one is probably good to go, can probably add additional spec related features as needed

@cmdcolin
Copy link
Collaborator Author

there is a chance the synteny launchview extension point could leverage the lgv launchview (it doesn't currently in this PR) but that will probably not affect things that much. can probably merge for now

@cmdcolin cmdcolin merged commit bffae77 into main Jun 10, 2022
@cmdcolin cmdcolin changed the title Add session spec for synteny views Add simplified URL format for loading synteny views Jun 10, 2022
@cmdcolin cmdcolin deleted the spec_synteny branch June 12, 2022 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant